Merged
Conversation
- Do not expire superblock triggers on execution - Expire trigger objects about 1 day (576 blocks) after their event height is past
schinzelh
approved these changes
Dec 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current code is expiring superblock triggers immediately after execution by miner block creation. This is not safe because there is no guarantee that these blocks will make it into the chain, so the triggers may be needed again.
With this change superblock triggers are expired only after a set number of blocks have past from their event height. The number chosen is 576 or 1 day. This should be enough to ensure that random forks won't reprocess the event block and allows some time for after the fact debugging.