fix updateDarksendProgress / add isDenominatedAmount and GetNormalizedAnonymizedBalance#136
Closed
UdjinM6 wants to merge 1 commit intodashpay:masterfrom
UdjinM6:fix_ds_progress
Closed
fix updateDarksendProgress / add isDenominatedAmount and GetNormalizedAnonymizedBalance#136UdjinM6 wants to merge 1 commit intodashpay:masterfrom UdjinM6:fix_ds_progress
UdjinM6 wants to merge 1 commit intodashpay:masterfrom
UdjinM6:fix_ds_progress
Conversation
…dAnonymizedBalance
|
Can you submit this to v11.1 instead? |
Author
|
Sure - #137 |
knst
pushed a commit
to knst/dash
that referenced
this pull request
Jul 12, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy) 303cfc6 allow darkmode on macos build (Sylvain Goumy) 78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab) Pull request description: Allow icons to be colorized on macOS to support native Dark mode color scheme. Rendering on macOS Big Sur before PR:  Rendering on macOS Big Sur after PR:  Light mode stay visually unchanged. <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del> <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del> Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build. Linked issues: dashpay#68 dashpay#136 ACKs for top commit: hebasto: re-ACK dc4551c jarolrod: ACK dc4551c Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
knst
pushed a commit
to knst/dash
that referenced
this pull request
Jul 23, 2024
dc4551c remove incompatibility release note for darkmode on macos (Sylvain Goumy) 303cfc6 allow darkmode on macos build (Sylvain Goumy) 78f75a2 Allow icon colorization on mac os to better support dark mode (Uplab) Pull request description: Allow icons to be colorized on macOS to support native Dark mode color scheme. Rendering on macOS Big Sur before PR:  Rendering on macOS Big Sur after PR:  Light mode stay visually unchanged. <del>Note, that this currently only affect the build from source, as the macos dmg includes an attributes to force light color scheme on macos windows (see bitcoin#14593). </del> <del>But once all glitches are fixed, we will be able to remove this temporary fix. </del> Edit: this PR is know including the removal of `NSRequiresAquaSystemAppearance` on Info.plist file so that the color fix is apply to every build. Linked issues: dashpay#68 dashpay#136 ACKs for top commit: hebasto: re-ACK dc4551c jarolrod: ACK dc4551c Tree-SHA512: 1c3a4dec796063e61fcaf80112afc2b15c8669a1cd30ebd537cea96647c20215f8f80289719f905820bb0c490c8c1f94bfae4bb32f9c6d1fdd4e8f199ebb559f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate progress out of two parts:
and apply some weights to them to calculate the whole progress (80/20 seems to be pretty smooth for me)
New functions: