Use override keyword for overriden class member functions#1644
Use override keyword for overriden class member functions#1644UdjinM6 merged 2 commits intodashpay:developfrom
override keyword for overriden class member functions#1644Conversation
|
Pinging @codablock - will this cause conflicts in bitcoin backports you are doing? |
|
Yeah, this touches quite a lot of methods. I'll stumble on this when doing a rebase after this is merged...probably in really many of my commit. I would suggest to leave this PR open until we have catched up with Bitcoin |
|
ok, postponing till later then |
|
Agree to hold off on touching bitcoin code for now, for this and other C++11 updates. src/governance-exceptions.h is Dash-specific so it can be changed, but it also has a deprecated Note that the src/drafted files are not used and will be removed at some point. |
|
As we have catched up with Bitcoin 0.14 now, we can probably finish this one. I'll handle merge conflicts for 0.15 later on-the-fly while I backport the PRs. |
|
Needs rebase |
gladcow
changed the title
override keyword for overriden class member functionsoverride keyword for overriden class member functions
gladcow
changed the title
override keyword for overriden class member functionsoverride keyword for overriden class member functions
gladcow
changed the title
override keyword for overriden class member functionsoverride keyword for overriden class member functions
gladcow
changed the title
override keyword for overriden class member functionsoverride keyword for overriden class member functions
4 participants
This helps to prevent errors when you change base class interface and descedant member function is not called after that.
Also, I've made the function GetHDChain in keystore.h virtual and the function with the same name in the wallet\crypter.h overriden, I think it is more correct if we have functions with the same name and signature in ancestor and descendant classes.