Switch nTimeLastSuccessfulStep from GetTimeMillis() to GetTime()#1923
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Feb 12, 2018
Merged
Switch nTimeLastSuccessfulStep from GetTimeMillis() to GetTime()#1923UdjinM6 merged 1 commit intodashpay:developfrom
UdjinM6 merged 1 commit intodashpay:developfrom
Conversation
This makes PS mockable. And we don't need that much of a precision here anyway.
codablock
reviewed
Feb 12, 2018
| int nLagTime = fMasternodeMode ? 0 : 10000; // if we're the client, give the server a few extra seconds before resetting. | ||
| int nTimeout = (nState == POOL_STATE_SIGNING) ? PRIVATESEND_SIGNING_TIMEOUT : PRIVATESEND_QUEUE_TIMEOUT; | ||
| bool fTimeout = GetTimeMillis() - nTimeLastSuccessfulStep >= nTimeout*1000 + nLagTime; | ||
| bool fTimeout = GetTime() - nTimeLastSuccessfulStep >= nTimeout; |
There was a problem hiding this comment.
Is the removal of + nLagTime also intended here?
Author
There was a problem hiding this comment.
yes, cause it's always 0 on masternode side :)
see - int nLagTime = fMasternodeMode ? 0 : 10000; above
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…hpay#1923) This makes PS mockable. And we don't need that much of a precision here anyway.
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 28, 2019
…hpay#1923) This makes PS mockable. And we don't need that much of a precision here anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes PS mockable. And we don't need that much of a precision here anyway.