Merged
Conversation
nmarley
approved these changes
Apr 10, 2018
nmarley
left a comment
nmarley
left a comment
There was a problem hiding this comment.
utACK
(Though I prefer smaller diff by keeping protocol version to 99999)
Author
|
As discussed in Slack, it would be better to completely remove the FEEFILTER code. I'll do this now and rename the PR accordingly. |
codablock
force-pushed
the
pr_disable_feefilter
branch
from
15e88ec to
7e51728
Compare
Author
|
Updated the PR to completely remove the FEEFILTER code |
codablock
force-pushed
the
pr_disable_feefilter
branch
from
7e51728 to
1e94f56
Compare
UdjinM6
requested changes
Apr 11, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Few leftovers otherwise looks good 👍
diff --git a/qa/pull-tester/rpc-tests.py b/qa/pull-tester/rpc-tests.py
index b978f7d5c..f280ad67f 100755
--- a/qa/pull-tester/rpc-tests.py
+++ b/qa/pull-tester/rpc-tests.py
@@ -182,7 +182,6 @@ testScriptsExt = [
'p2p-timeouts.py',
# vv Tests less than 60s vv
'bip9-softforks.py',
- 'p2p-feefilter.py',
'rpcbind_test.py',
# vv Tests less than 30s vv
'bip65-cltv.py',
diff --git a/qa/rpc-tests/p2p-leaktests.py b/qa/rpc-tests/p2p-leaktests.py
index 41ca84d77..b9d8e851a 100755
--- a/qa/rpc-tests/p2p-leaktests.py
+++ b/qa/rpc-tests/p2p-leaktests.py
@@ -55,7 +55,6 @@ class CLazyNode(NodeConnCB):
def on_ping(self, conn, message): self.bad_message(message)
def on_mempool(self, conn): self.bad_message(message)
def on_pong(self, conn, message): self.bad_message(message)
- def on_feefilter(self, conn, message): self.bad_message(message)
def on_sendheaders(self, conn, message): self.bad_message(message)
def on_sendcmpct(self, conn, message): self.bad_message(message)
def on_cmpctblock(self, conn, message): self.bad_message(message)
This reverts commit 11ac70a.
codablock
force-pushed
the
pr_disable_feefilter
branch
from
1e94f56 to
200253b
Compare
Author
|
@UdjinM6 Sorry, missed these 2. Fixed and force pushed :) |
|
Needs rebase |
|
utACK |
|
This one was caused by cmctblock merge, so was a trivial one. Fixed it via github GUI. |
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until we clarify if https://jasonc.me/blog/bitcoin-bip-133-double-spends-bch
is really a problem for us.