[WIP] Tweak UI design (overview screen, bg and toolbar)#2204
Closed
UdjinM6 wants to merge 2 commits intodashpay:developfrom
Closed
[WIP] Tweak UI design (overview screen, bg and toolbar)#2204UdjinM6 wants to merge 2 commits intodashpay:developfrom
UdjinM6 wants to merge 2 commits intodashpay:developfrom
Conversation
Collaborator
|
Looks like it is a little difficult to tell which item (Overview/Send/Receive/etc.) is selected in the new screenshot since the selected item is not a different colour. 🤔 |
|
Agree, selected TAB should be different color. Edit: Maybe underline to the selected TAB text, green, yellow or white. |
|
I like the progress so far. Would be great to remove the red lines and new icons in the tabs as well which align w/new guidelines for style and colors. |
Member
|
JeffH complained to me not too long ago, that at weird proportions, the background / logo was stretched and augmented, which is against the style guide. That might be annoying to change since QT, but since you're working in that realm thought I might as well mention it. |
Author
|
Closing in fav of #3000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just experimenting and trying to make UI a bit cleaner and closer to our new style guide...
Current:
This PR:
Note: Current implementation overrides
lighttheme and does not preserve the "old layout/new logo" theme. It also removes annoying red out-of-sync labels fromlighttheme.