add compressed option to masternode genkey#2232
Merged
UdjinM6 merged 3 commits intodashpay:developfrom Aug 21, 2018
Merged
Conversation
UdjinM6
reviewed
Aug 19, 2018
src/rpc/masternode.cpp
Outdated
| { | ||
| bool fCompressed = false; | ||
| if (request.params.size() > 1) { | ||
| fCompressed = (request.params[1].get_str() == "true"); |
There was a problem hiding this comment.
Could use new ParseBoolV instead (introduced in #2211 ).
src/rpc/masternode.cpp
Outdated
| " count - Get information about number of masternodes (DEPRECATED options: 'total', 'ps', 'enabled', 'qualify', 'all')\n" | ||
| " current - Print info on current masternode winner to be paid the next block (calculated locally)\n" | ||
| " genkey - Generate new masternodeprivkey\n" | ||
| " genkey - Generate new masternodeprivkey (optional param: boolean, optional, default=false) generate compressed privkey\n" |
There was a problem hiding this comment.
maybe , optional param: 'compressed' - (boolean, optional, default=false) generate compressed privkey ?
Author
|
Thanks for the tip! The new method seems to work perfectly for this case. |
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
Oct 23, 2018
- Add `compressed` parameter - Related to dashpay/dash#2232
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Nov 19, 2018
- Add `compressed` parameter - Related to dashpay/dash#2232
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Apr 25, 2019
* add compressed option to `masternode genkey` * use ParseBoolV method * adjust help message for masternode genkey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows anyone to generate / display compressed private keys using
masternode genkey. Prior to this change only the uncompressed format is displayed.I don't like the "string that looks like bool" option but I've tried and unsure how else to get this to a true bool since
genkeyis a subcommand. Might have to change the help text to reflect this, I'm up for suggestions.