Revert CMasternodePayments::IsTransactionValid to the logic before the recent refactorings#2237
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Aug 27, 2018
Merged
Conversation
…e recent refactorings
codablock
added a commit
to codablock/dash
that referenced
this pull request
Aug 27, 2018
codablock
added a commit
to codablock/dash
that referenced
this pull request
Sep 5, 2018
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Apr 25, 2019
…e recent refactorings (dashpay#2237) partially reverts dashpay#2216
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple problems slipped in with the refactorings, all related to different (or completely missing) handling of MN payment votes. Better to revert this method for now and only use the new/refactored logic in the DIP3 branch when spork15 activates.