Still support "protx list" and "protx diff" when wallet is disabled at compile time#2511
Merged
UdjinM6 merged 6 commits intodashpay:developfrom Nov 29, 2018
Merged
Conversation
UdjinM6
requested changes
Nov 29, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good 👍
Just one small issue, see below
This now also handles the case where ENABLE_WALLET is not defined.
codablock
force-pushed
the
pr_dip3_protxnowallet
branch
from
68a8e90 to
0a8fffe
Compare
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Jun 29, 2020
…t compile time (dashpay#2511) * Don't fully remove protx commands when ENABLE_WALLET is not set * Check for wallet support at run-time for protx commands * Only show subcommands that require the wallet when ENABLE_WALLET is set * Add and use CheckWalletOwnsKey which is able to check wallet support at runtime * Properly handle disabled wallets in "protx list" This now also handles the case where ENABLE_WALLET is not defined. * Drop comment that doesn't fully apply anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#ifdef ENABLE_WALLETwas surrounding allprotxcommands and also disabled the ones that should work without a wallet. This PR allows to uselistanddiffnow.