Backports 0.15 pr1 by PastaPastaPasta · Pull Request #2590 · dashpay/dash

PastaPastaPasta · 2018-12-28T19:04:07Z

No description provided.

UdjinM6

095cb16 - missing changes in qa/rpc-tests/p2p-compactblocks.py
240a3a6 - missing a lot of changes
1821244 - missing changes in src/qt/forms/intro.ui

qa/pull-tester/rpc-tests.py

qa/pull-tester/tests_config.ini.in

a432aa0 Remove unused module from rpc-tests (Takashi Mitsuta)

0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)

a6a3e58 Various review markups for rpc-tests.py improvements (John Newbery) 3de3ccd Refactor rpc-tests.py (John Newbery) afd38e7 Improve rpc-tests.py arguments (John Newbery) 91bffff Use argparse in rpc_tests.py (John Newbery) 1581ecb Use configparser in rpc-tests.py (John Newbery)

f6d18f5 Qt/Intro: Explain a bit more what will happen first time (Luke Dashjr) 50c5657 Qt/Intro: Storage shouldn't grow significantly with pruning enabled (Luke Dashjr) 9adb694 Qt/Intro: Move sizeWarningLabel text into C++ code (Luke Dashjr)

1bfe6b4 Use package name variable inside $(package)_file_name variable (Mitchell Cash)

…outs through proxy 3ddfe29 netbase: Do not print an error on connection timeouts through proxy (Wladimir J. van der Laan) 13f6085 netbase: Make InterruptibleRecv return an error code instead of bool (Wladimir J. van der Laan)

056aba2 Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan)

b471daf Adddress nits, use asyncio signal handling, create_task (Bob McElrath) 4bb7d1b Add python version checks and 3.4 example (Bob McElrath) 5406d51 Rewrite to not use Polling wrapper for asyncio, link to python2.7 example (Bob McElrath) 5ea5368 ZMQ example using python3 and asyncio (Bob McElrath)

851f6a3 [qa][doc] Correct rpc test options in readme (fanquake) 41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake)

UdjinM6

Looks good in general but still have to rollback permissions changes in
contrib/zmq/zmq_sub.py 100755 → 100644
qa/pull-tester/rpc-tests.py 100755 → 100644
qa/rpc-tests/p2p-compactblocks.py 100755 → 100644

Plus see few suggestions for some dashification.

qa/pull-tester/rpc-tests.py

src/qt/intro.cpp

Co-Authored-By: PastaPastaPasta <[email protected]>

UdjinM6

utACK

codablock

See inline comment.

codablock · 2019-01-02T09:13:18Z

qa/pull-tester/rpc-tests.py

+    parser.add_argument('--extended', action='store_true', help='run the extended test suite in addition to the basic tests')
+    parser.add_argument('--force', '-f', action='store_true', help='run tests even on platforms where they are disabled by default (e.g. windows).')
+    parser.add_argument('--help', '-h', '-?', action='store_true', help='print help text and exit')
+    parser.add_argument('--jobs', '-j', type=int, default=4, help='how many test scripts to run in parallel. Default=4.')


This looks like you'll also have to update:

dash/.travis.yml

Line 76 in f65e746

- test "$DEPENDS_TIMEOUT" != "true" && $DOCKER_RUN_IN_BUILDER ./ci/test_integrationtests.sh -parallel=3

The -parallel flag seems to have been replaced with --jobs

UdjinM6

re-utACK

Hmm.. test are failing in some weird way

UdjinM6 · 2019-01-03T02:00:06Z

Looks like test failures are semi-related and should be fixed by #2603. Well, at least tests fail in their usual manner https://travis-ci.org/UdjinM6/dash/builds/474659810 after applying the patch.

UdjinM6

re-utACK with #2603 to be merged right after this one

codablock · 2019-01-03T05:34:00Z

I'd prefer to have #2603 merged first and this one rebased afterwards. Otherwise we'd merge this one without tests being run.

UdjinM6 · 2019-01-03T08:58:04Z

Otherwise we'd merge this one without tests being run.

You can see test results for this branch with the patch from #2603 applied on top in the link I provided above (https://travis-ci.org/UdjinM6/dash/builds/474659810).

codablock

utACK

UdjinM6 added this to the 14.0 milestone Dec 28, 2018

UdjinM6 requested changes Dec 28, 2018

View reviewed changes

qa/pull-tester/rpc-tests.py Outdated Show resolved Hide resolved

qa/pull-tester/rpc-tests.py Outdated Show resolved Hide resolved

qa/pull-tester/tests_config.ini.in Outdated Show resolved Hide resolved

PastaPastaPasta force-pushed the backports-0.15-pr1 branch from 748fcc1 to 8a71042 Compare December 29, 2018 05:43

MarcoFalke and others added 9 commits December 28, 2018 23:46

Merge bitcoin#9744: Remove unused module from rpc-tests

ce88e2e

a432aa0 Remove unused module from rpc-tests (Takashi Mitsuta)

Merge bitcoin#9696: [trivial] Fix recently introduced typos in comments

3af098d

0c9b9b7 [trivial] Fix recently introduced typos in comments (practicalswift)

Merge bitcoin#9794: Minor update to qrencode package builder

ae5303b

1bfe6b4 Use package name variable inside $(package)_file_name variable (Mitchell Cash)

Merge bitcoin#9727: Remove fallbacks for boost_filesystem < v3

ed8ed9b

056aba2 Remove fallbacks for boost_filesystem < v3 (Wladimir J. van der Laan)

Merge bitcoin#9807: RPC doc fix-ups.

b32d26e

851f6a3 [qa][doc] Correct rpc test options in readme (fanquake) 41e7219 [trivial] Add tests_config.ini to .gitignore (fanquake)

PastaPastaPasta force-pushed the backports-0.15-pr1 branch from 8a71042 to b32d26e Compare December 29, 2018 05:47

UdjinM6 requested changes Dec 29, 2018

View reviewed changes

qa/pull-tester/rpc-tests.py Outdated Show resolved Hide resolved

qa/pull-tester/rpc-tests.py Outdated Show resolved Hide resolved

src/qt/intro.cpp Outdated Show resolved Hide resolved

src/qt/intro.cpp Outdated Show resolved Hide resolved

UdjinM6 and others added 2 commits December 29, 2018 01:38

Dashify

2859a47

Co-Authored-By: PastaPastaPasta <[email protected]>

Change file permissions

4529ea5

PastaPastaPasta force-pushed the backports-0.15-pr1 branch from fe5ae54 to 4529ea5 Compare December 29, 2018 19:27

UdjinM6 previously approved these changes Dec 31, 2018

View reviewed changes

UdjinM6 requested a review from codablock January 1, 2019 21:10

codablock reviewed Jan 2, 2019

View reviewed changes

update travis.yml -parallel -> --jobs

ba1fb73

PastaPastaPasta dismissed UdjinM6’s stale review via ba1fb73 January 2, 2019 21:50

UdjinM6 previously approved these changes Jan 2, 2019

View reviewed changes

UdjinM6 mentioned this pull request Jan 3, 2019

De-dashify env vars and dashify help text in tests instead #2603

Merged

UdjinM6 approved these changes Jan 3, 2019

View reviewed changes

codablock approved these changes Jan 3, 2019

View reviewed changes

UdjinM6 merged commit a49f412 into dashpay:develop Jan 3, 2019

PastaPastaPasta deleted the backports-0.15-pr1 branch January 3, 2019 14:41

Conversation

PastaPastaPasta commented Dec 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

codablock Jan 2, 2019

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Jan 3, 2019

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

codablock commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 commented Jan 3, 2019

Uh oh!

codablock left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PastaPastaPasta commented Dec 28, 2018 •

edited

Loading

codablock commented Jan 3, 2019 •

edited

Loading