Implement persistence for LLMQ based InstantSend#2756
Merged
codablock merged 12 commits intodashpay:developfrom Mar 12, 2019
Merged
Implement persistence for LLMQ based InstantSend#2756codablock merged 12 commits intodashpay:developfrom
codablock merged 12 commits intodashpay:developfrom
Conversation
Was never used.
This DB is for LLMQ related data that is not part of on-chain consensus. This for example included LLMQ secret key shares and recovered signatures.
Contributions are not part of on-chain consensus and shouldn't be stored in CEvoDB.
Instead of creating its own CDBWrapper internally.
This avoids future conflicts with other data stored in llmqDb
These just pass through to CRecoveredSigsDb
UdjinM6
reviewed
Mar 11, 2019
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good 👍
Just a couple of tiny nits, see below.
UdjinM6
removed
the
RPC
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes finished/final InstantSend locks persistent, which means they are still present after restart of the node.
It also introduces
unordered_lru_cacheforCInstantSendDband also switchesCRecoveredSigsDbto use it as well.