Changed DRK references to DASH in the start-many guide.#283
Closed
perrywoodin wants to merge 1 commit intodashpay:masterfrom
node40:dash-start-many-guide
Closed
Changed DRK references to DASH in the start-many guide.#283perrywoodin wants to merge 1 commit intodashpay:masterfrom node40:dash-start-many-guide
perrywoodin wants to merge 1 commit intodashpay:masterfrom
node40:dash-start-many-guide
Conversation
|
The 0.11.2.x branch is going to be released next week and it contains these fixes. There's a couple differences that it doesn't cover, MasterNodes -> Masternodes, if you want to submit that feel free to do it in the v0.11.2.x branch. Thanks! |
knst
pushed a commit
to knst/dash
that referenced
this pull request
Aug 5, 2024
5a4a15d qt, refactor: Drop no longer used PeerTableModel::getRowByNodeId func (Hennadii Stepanov) 9a9f180 qt, refactor: Drop no longer used PeerTableModel::sort function (Hennadii Stepanov) 778a64a qt: Use PeerTableSortProxy for sorting peer table (Hennadii Stepanov) df2d165 qt: Add peertablesortproxy module (Hennadii Stepanov) Pull request description: The "Peers" table in the "Node" window does not hold multiple selection after sorting. This PR introduces a `QSortFilterProxyModel` subclass, that is a standard Qt [practice](https://doc.qt.io/qt-5/model-view-programming.html#custom-sorting-models) for such cases. Now the sorting code is encapsulated into the dedicated Qt class, and we do not need to maintain it. Fixes dashpay#283 (additionally). --- On **master** (7ae86b3): - rows are sorted by "Ping", and a selection is made  - rows are sorted by "NodeId", and the previous selection is _lost_  With **this PR**: - rows are sorted by "Ping", and a selection is made  - rows are sorted by "NodeId", and the row are still selected  ACKs for top commit: jarolrod: re-ACK 5a4a15d, tested on macOS 11.2 Qt 5.15.2 after rebase promag: Tested ACK 5a4a15d. Tree-SHA512: f81c1385892fbf1a46ffb98b42094ca1cc97da52114bbbc94fedb553899b1f18c26a349e186bba6e27922a89426bd61e8bc88b1f7832512dbe211b5f834e076e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.