Wait for the actual best block chainlock in llmq-chainlocks.py#3109
Merged
codablock merged 2 commits intodashpay:developfrom Sep 27, 2019
Merged
Wait for the actual best block chainlock in llmq-chainlocks.py#3109codablock merged 2 commits intodashpay:developfrom
codablock merged 2 commits intodashpay:developfrom
Conversation
|
Test failure is due to retroactive signing taking longer then 15 seconds (was very close as of logs). This did not happen before because we were waiting for a too early CLSIG before. Increasing the timeout in |
codablock
approved these changes
Sep 25, 2019
codablock
left a comment
codablock
left a comment
There was a problem hiding this comment.
re-utACK
Build failure is unrelated and should be fixed in a separate PR (https://github.com/dashpay/dash/blob/develop/test/functional/wallet-encryption.py#L45 should be bumped to 3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 0 is the one with the longest chain (and the one that should propagate it to other nodes), node 1 might not have the best block right after the reconnect.