Skip to content

Qt: Remove old themes#3141

Merged
UdjinM6 merged 11 commits intodashpay:developfrom
nmarley:qt-remove-old-themes
Oct 10, 2019
Merged

Qt: Remove old themes#3141
UdjinM6 merged 11 commits intodashpay:developfrom
nmarley:qt-remove-old-themes

Conversation

@nmarley
Copy link

@nmarley nmarley commented Oct 8, 2019

This is split out from #3000 and removes all except the "light" theme in preparation for a bit more extensive refresh. This refresh moves images and layout around and won't work with the current theme layout.

@UdjinM6
Copy link

UdjinM6 commented Oct 8, 2019

This basically leaves us with one single theme again and what it means is that we don't have to care about themes for any kind of images at all now and thus we can "squash" things like this UdjinM6@721288e. Also, we can finally clean up some legacy drkblue mess UdjinM6@06e1f59.

And I would actually keep the Traditional theme - it requires almost no additional code and no images after the "squashing" commit, so it's very lightweight (UdjinM6@b190fd8) but it can be very useful for people running qt wallets in weird environments (some exotic linux distros, crazy small resolutions etc.). I know that at least some people were actually using this theme at some point.

@codablock
Copy link

Big fan of removing the themes mess as proposed by UdjinM6 👍

@nmarley
Copy link
Author

nmarley commented Oct 9, 2019

Agree on removing themes and cleaning up drkblue. Traditional seems to still work so don't mind either way on that one. FF'ed to 06e1f59.

@UdjinM6 UdjinM6 added this to the 14.1 milestone Oct 9, 2019
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly tested ACK

@UdjinM6
Copy link

UdjinM6 commented Oct 9, 2019

Travis failed due to some (unrelated) apt-get timeout issues.

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 1cbe280 into dashpay:develop Oct 10, 2019
@nmarley nmarley deleted the qt-remove-old-themes branch October 10, 2019 14:19
andrewtookay pushed a commit to Alterdot/Alterdot that referenced this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants