Merged
Conversation
We removed "alert" p2p message and changed "mempool" message behaviour a bit. It probably makes sense to bump PROTOCOL_VERSION now. This should also help to distinguish v0.15 nodes from late v0.14.0.x ones.
|
Something to consider for https://github.com/nightlydash/dash-seeder as well? |
Author
|
@schinzelh yep, good point 👍 (actually, it's 70215 already but it won't hurt to keep things aligned nightlydash/dash-seeder#24) |
UdjinM6
changed the title
UdjinM6
force-pushed
the
bumpprotos202001
branch
from
b0c5dc4 to
aa144e4
Compare
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Jan 14, 2020
- Related to dashpay/dash#3287
thephez
added a commit
to thephez/dash-docs
that referenced
this pull request
Jan 14, 2020
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2020
We removed "alert" p2p message and changed "mempool" message behaviour a bit. It probably makes sense to bump PROTOCOL_VERSION now. This should also help to distinguish v0.15 nodes from late v0.14.0.x ones.
thephez
added a commit
to dash-docs/dash-docs
that referenced
this pull request
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale:
We no longer need to support pre-v0.14 nodes.We do have quite a few mobile SPV wallets running on low end Android phones though. Postponing MIN_PEER_PROTO_VERSION bump till later.