Replace generic CScopedDBTransaction with specialized CEvoDBScopedCommitter#3292
Merged
codablock merged 1 commit intodashpay:developfrom Jan 17, 2020
Merged
Conversation
…mitter This has the wanted side effect of proper locking of "cs" inside CommitCurTransaction and RollbackCurTransaction, which was not easily possible to implement in the generic version. This fixes some rare crashes.
codablock
added a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2020
…mitter (dashpay#3292) This has the wanted side effect of proper locking of "cs" inside CommitCurTransaction and RollbackCurTransaction, which was not easily possible to implement in the generic version. This fixes some rare crashes.
|
Base missing codablock@5857ec7#diff-789e7d6ecebb8de86cb5bb9f6ba0b6e4? |
|
@charlesrocket can you clarify pls? |
|
this pr’s base missing the commit above as it looks like |
|
Is it? Hmm... I don't see anything wrong, it looks exactly as expected imo https://github.com/dashpay/dash/pull/3292/files#diff-789e7d6ecebb8de86cb5bb9f6ba0b6e4L739 |
Author
|
@charlesrocket As @UdjinM6 already noted, the changes from the mentioned commit are inside develop already. However, the v0.15.x branch is missing the mentioned changes, so the backported version of this PR looked slightly different, but it was an easy conflict resolution as the affected code was removed nevertheless. |
FornaxA
pushed a commit
to ioncoincore/ion
that referenced
this pull request
Jul 6, 2020
…mitter (dashpay#3292) This has the wanted side effect of proper locking of "cs" inside CommitCurTransaction and RollbackCurTransaction, which was not easily possible to implement in the generic version. This fixes some rare crashes. Signed-off-by: cevap <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the wanted side effect of proper locking of "cs" inside
CommitCurTransaction and RollbackCurTransaction, which was not easily
possible to implement in the generic version. This fixes some rare crashes.
Example of a crash that is fixed by this: https://gitlab.com/dashpay/dash/-/jobs/406218969#L3504