Merge #12193: RPC: Consistently use UniValue.pushKV instead of push_back(Pair()) (karel-3d)#3532
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Jun 18, 2020
Merged
Conversation
PastaPastaPasta
force-pushed
the
backport-12193
branch
from
9ad08f7 to
87e70c8
Compare
…itcoin#12193) -BEGIN VERIFY SCRIPT- git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g" -END VERIFY SCRIPT- Signed-off-by: pasta <[email protected]>
PastaPastaPasta
force-pushed
the
backport-12193
branch
from
87e70c8 to
f7f8a35
Compare
Member
Author
|
rebased, scripted diff passes :) |
PastaPastaPasta
changed the title
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Feb 23, 2022
…f push_back(Pair()) (karel-3d) (dashpay#3532) * Begin Merge 12193 Squashed 'src/univalue/' changes from 07947ff2da..51d3ab34ba 51d3ab34ba Merge dashpay#10: Add pushKV(key, boolean) function (replaces dashpay#5) 129bad96d5 [tests] test pushKV for boolean values b3c44c947f Pushing boolean value to univalue correctly git-subtree-dir: src/univalue git-subtree-split: 51d3ab34ba2857f0d03dc07250cb4a2b5e712e67 * scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (end bitcoin#12193) -BEGIN VERIFY SCRIPT- git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g" -END VERIFY SCRIPT- Signed-off-by: pasta <[email protected]> Co-authored-by: MarcoFalke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on pr4