qt: Disable macOS system focus rectangles for dash themes#3556
Merged
UdjinM6 merged 2 commits intodashpay:developfrom Jul 8, 2020
Merged
qt: Disable macOS system focus rectangles for dash themes#3556UdjinM6 merged 2 commits intodashpay:developfrom
UdjinM6 merged 2 commits intodashpay:developfrom
Conversation
This was referenced Jun 26, 2020
xdustinface
force-pushed
the
pr-ui-3-macos-focus-rect
branch
2 times, most recently
from
03bf95c to
3d2fed7
Compare
xdustinface
force-pushed
the
pr-ui-3-macos-focus-rect
branch
from
3d2fed7 to
978478c
Compare
The focus rects drawn by macOS are in the color the user selected in the OS settings as selection color. This just doesn't always fit into the coloring of the dash specific themes.
xdustinface
force-pushed
the
pr-ui-3-macos-focus-rect
branch
from
978478c to
5bbd4ef
Compare
PastaPastaPasta
previously approved these changes
Jul 7, 2020
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK, I can't test this, basically all I'm attesting to is that this doesn't look malicious, nor does it break style guide
UdjinM6
requested changes
Jul 8, 2020
Co-authored-by: UdjinM6 <[email protected]>
UdjinM6
approved these changes
Jul 8, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Slightly tested ACK, works as expected it seems
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 1, 2020
* qt: Disable macOS system focus rectangles for dash themes The focus rects drawn by macOS are in the color the user selected in the OS settings as selection color. This just doesn't always fit into the coloring of the dash specific themes. * Apply review suggestion Co-authored-by: UdjinM6 <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: Disable macOS system focus rectangles for dash themes The focus rects drawn by macOS are in the color the user selected in the OS settings as selection color. This just doesn't always fit into the coloring of the dash specific themes. * Apply review suggestion Co-authored-by: UdjinM6 <[email protected]> Co-authored-by: UdjinM6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3555, its successor is #3557. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
This PR disables all focus rects drawn by macOS for dash themes. The focus rects drawn by macOS are in the color the user selected in the OS settings as selection color. This just doesn't always fit into the coloring of the dash specific themes.