qt: General qt/c++ related fixes and updates by xdustinface · Pull Request #3562 · dashpay/dash

xdustinface · 2020-06-26T14:12:02Z

This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3561, its successor is #3563. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.

-> Walk through 0.15
-> Walk through Redesign

I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.

About this PR

See individual commit messages.

xdustinface · 2020-07-14T14:52:34Z

Ready for review!

xdustinface · 2020-07-14T15:37:55Z

Build will fail until #3558 is merged.

xdustinface · 2020-07-14T22:00:55Z

Rebased to fix the build!

UdjinM6 · 2020-07-16T12:17:53Z

Looks good in general but "Last PrivateSend Message" appearance is pretty weird now imo. It wasn't looking very nice before either and wasn't that helpful too tbh. I think we could just drop it completely and make things look much nicer here (e5e64c3197).

xdustinface · 2020-07-16T12:49:47Z

Agreed and picked! If it makes any sense i would consider to add this again later with a better layout in a different place as i have some plans in mind to give private send a completely reworked UI in a separate tab if thats something we want to have. Nothing worth to discuss at this point but i will let you know when i have more specific thoughts there.

UdjinM6

ACK

UdjinM6 · 2020-07-16T23:42:34Z

Needs rebase.

waiting for rebase

- Fix issue with bluriness - Refine sizing/layout of QR code and address - Adjust coloring to match the themes

Required to access it in css

- Was named the same as the the label in EditAddressDialog so it couldn't be accessed properly in css

- Hide denom labels if inactive - Enable wordwrap for denom label - Add some spacer - Make sure it gets its basic initialization on startup

- Added some margins for fee selection radio buttons to align them centered to their options - Removed a weird placed spacer

- Inheritance doesn't work here obviously because of QCompleter is parent of the popup - QStyledItemDelegate delegate is required. Without its not possible to access `::item` selectors from css.

Its obviously not possible to do this in stylesheets thats why i added this as workaround.

This is the datadir selection dialog.

xdustinface · 2020-07-17T00:00:34Z

Thanks, didn't notice.. done 👍

UdjinM6

re-ACK

src/qt/transactionview.cpp

Co-authored-by: PastaPastaPasta <[email protected]>

PastaPastaPasta

See attached problems in photos. Not sure if this PR introduced, or if I should copy these over to the issue

xdustinface · 2020-07-18T17:38:07Z

The issue in the last image will be fixed by #3573. The others are not related to this PR so maybe just post it in #3578 (do you run with -font-scale?).

PastaPastaPasta · 2020-07-18T18:00:55Z

The issue in the last image will be fixed by #3573. The others are not related to this PR so maybe just post it in #3578 (do you run with -font-scale?).

Nope, not running with -font-scale

PastaPastaPasta

ACK

UdjinM6

ACK

* qt: Draw a border around net traffic graph * qt: ReceiveRequestDialog - Improve QR code image - Fix issue with bluriness - Refine sizing/layout of QR code and address - Adjust coloring to match the themes * qt: Give the TransactionView's instantsendWidget a name Required to access it in css * qt: Rename conflicting label in SendCoinsDialog - Was named the same as the the label in EditAddressDialog so it couldn't be accessed properly in css * qt: Give the TransactionView's search field the first focus on startup * qt: Some updates to the PrivateSend widget on the OverviewPage - Hide denom labels if inactive - Enable wordwrap for denom label - Add some spacer - Make sure it gets its basic initialization on startup * qt: Fix some layout issues in SendCoinsDialog's UI file. - Added some margins for fee selection radio buttons to align them centered to their options - Removed a weird placed spacer * qt: Fix vertical alignment of the two balance labels in SendCoinsDialog * qt: Add newline in textedit of receiverequest * qt: OptionsDialog - Hide override hint if there is nothing overridden * qt: Allow stylesheet modifications for auto completition popup - Inheritance doesn't work here obviously because of QCompleter is parent of the popup - QStyledItemDelegate delegate is required. Without its not possible to access `::item` selectors from css. * qt: Make the progress label in the status bar accessible in css * qt: Update weekend colors of QCalendarWidget on style changes Its obviously not possible to do this in stylesheets thats why i added this as workaround. * qt: Load stylesheets for Intro This is the datadir selection dialog. * Drop labelPrivateSendLastMessage * Add a space Co-authored-by: PastaPastaPasta <[email protected]> Co-authored-by: UdjinM6 <[email protected]> Co-authored-by: PastaPastaPasta <[email protected]>

This was referenced Jun 26, 2020

qt: General CSS related redesigns #3563

Merged

qt: Make use of GUIUtil themed colors/styles #3561

Merged

xdustinface force-pushed the pr-ui-9-qt-code-updates branch 2 times, most recently from b6590ae to e2be853 Compare June 27, 2020 20:23

xdustinface marked this pull request as draft June 30, 2020 20:19

xdustinface force-pushed the pr-ui-9-qt-code-updates branch from e2be853 to 844bee5 Compare July 14, 2020 14:51

xdustinface marked this pull request as ready for review July 14, 2020 14:52

xdustinface force-pushed the pr-ui-9-qt-code-updates branch from 844bee5 to a378c98 Compare July 14, 2020 15:27

xdustinface force-pushed the pr-ui-9-qt-code-updates branch from d1bf5e9 to 5bb5a02 Compare July 14, 2020 22:00

UdjinM6 added this to the 17 milestone Jul 16, 2020

UdjinM6 previously approved these changes Jul 16, 2020

View reviewed changes

xdustinface added 12 commits July 17, 2020 01:57

qt: Draw a border around net traffic graph

2a19773

qt: ReceiveRequestDialog - Improve QR code image

567e038

- Fix issue with bluriness - Refine sizing/layout of QR code and address - Adjust coloring to match the themes

qt: Give the TransactionView's instantsendWidget a name

67f7a72

Required to access it in css

qt: Rename conflicting label in SendCoinsDialog

148611f

- Was named the same as the the label in EditAddressDialog so it couldn't be accessed properly in css

qt: Give the TransactionView's search field the first focus on startup

522c0c3

qt: Some updates to the PrivateSend widget on the OverviewPage

d1600a8

- Hide denom labels if inactive - Enable wordwrap for denom label - Add some spacer - Make sure it gets its basic initialization on startup

qt: Fix some layout issues in SendCoinsDialog's UI file.

4d28b60

- Added some margins for fee selection radio buttons to align them centered to their options - Removed a weird placed spacer

qt: Fix vertical alignment of the two balance labels in SendCoinsDialog

7138101

qt: Add newline in textedit of receiverequest

8ad2aee

qt: OptionsDialog - Hide override hint if there is nothing overridden

450e08d

qt: Allow stylesheet modifications for auto completition popup

efae41e

- Inheritance doesn't work here obviously because of QCompleter is parent of the popup - QStyledItemDelegate delegate is required. Without its not possible to access `::item` selectors from css.

qt: Make the progress label in the status bar accessible in css

35c3386

xdustinface and others added 3 commits July 17, 2020 01:57

qt: Update weekend colors of QCalendarWidget on style changes

0ff45ec

Its obviously not possible to do this in stylesheets thats why i added this as workaround.

qt: Load stylesheets for Intro

cc31977

This is the datadir selection dialog.

Drop labelPrivateSendLastMessage

9a25fb3

xdustinface force-pushed the pr-ui-9-qt-code-updates branch from 3f527a0 to 9a25fb3 Compare July 17, 2020 00:00

UdjinM6 previously approved these changes Jul 17, 2020

View reviewed changes

xdustinface mentioned this pull request Jul 17, 2020

Qt redesign issues #3578

Open

PastaPastaPasta requested changes Jul 18, 2020

View reviewed changes

src/qt/transactionview.cpp Outdated Show resolved Hide resolved

Add a space

81e0908

Co-authored-by: PastaPastaPasta <[email protected]>

xdustinface dismissed UdjinM6’s stale review via 81e0908 July 18, 2020 16:54

PastaPastaPasta reviewed Jul 18, 2020

View reviewed changes

PastaPastaPasta approved these changes Jul 18, 2020

View reviewed changes

UdjinM6 approved these changes Jul 20, 2020

View reviewed changes

UdjinM6 merged commit 354ff23 into dashpay:develop Jul 20, 2020

Conversation

xdustinface commented Jun 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About this PR

Uh oh!

xdustinface commented Jul 14, 2020

Uh oh!

xdustinface commented Jul 14, 2020

Uh oh!

xdustinface commented Jul 14, 2020

Uh oh!

UdjinM6 commented Jul 16, 2020

Uh oh!

xdustinface commented Jul 16, 2020

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 commented Jul 16, 2020

Uh oh!

xdustinface commented Jul 17, 2020

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

xdustinface commented Jul 18, 2020

Uh oh!

PastaPastaPasta commented Jul 18, 2020

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xdustinface commented Jun 26, 2020 •

edited

Loading