qt: Add missing placeholders#3575
Merged
UdjinM6 merged 7 commits intodashpay:developfrom Jul 27, 2020
Merged
Conversation
xdustinface
force-pushed
the
pr-ui-22-placeholder
branch
2 times, most recently
from
3a88836 to
b9fe4dd
Compare
xdustinface
force-pushed
the
pr-ui-22-placeholder
branch
from
b9fe4dd to
215ff5d
Compare
Author
|
Ready for review! |
UdjinM6
reviewed
Jul 22, 2020
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Looks good and works as expected but I'm not sure about the wording, pls see suggestions below.
|
Needs rebase |
Co-authored-by: UdjinM6 <[email protected]>
xdustinface
force-pushed
the
pr-ui-22-placeholder
branch
from
745075c to
742f94d
Compare
Author
|
Rebased! |
xdustinface
added a commit
to xdustinface/dash
that referenced
this pull request
Sep 3, 2020
* qt: Add more placeholder in ReceiveCoinsDialog * qt: Add placeholder for filter line edit in MasternodeList * qt: Add more placerholder in SignVerifyMessageDialog * qt: Removes a dot * qt: Adjust placeholder phrasing in ReceiveCoinsDialog * Apply suggestions from code review * qt: Align wording of placeholders with the corresponding tooltip
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 3, 2022
* qt: Add more placeholder in ReceiveCoinsDialog * qt: Add placeholder for filter line edit in MasternodeList * qt: Add more placerholder in SignVerifyMessageDialog * qt: Removes a dot * qt: Adjust placeholder phrasing in ReceiveCoinsDialog * Apply suggestions from code review Co-authored-by: UdjinM6 <[email protected]> * qt: Align wording of placeholders with the corresponding tooltip Co-authored-by: UdjinM6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ist part of a series of +-25 PRs related to UI redesigns. Its ancestor is #3574, its successor is #3613. I did not screenshot every single PR and its changes, instead i made "walk through all screen" videos with the result of this PR series and also with the 0.15 UI. If there are any concrete screenshots wanted, just let me know. To build with the full set of changes you can build from the branch xdustinface:pr-ui-redesign which always contains all changes.
-> Walk through 0.15
-> Walk through Redesign
I tried to give the commits enough text to make things obvious without a lot description for each PR. Also here, if you want more description for this specific PR, let me know.
About this PR
See individual commit messages.