Change litemode to disablegovernance#3577
Merged
UdjinM6 merged 3 commits intodashpay:developfrom Jun 28, 2020
Merged
Conversation
PastaPastaPasta
force-pushed
the
change-litemode-disablegovernance
branch
from
1ac807a to
b5a8fb7
Compare
Member
Author
|
Ready for review. Tested locally. Seems to be working as expected |
…hat flag actually does. Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
PastaPastaPasta
force-pushed
the
change-litemode-disablegovernance
branch
from
15ffe57 to
72bdaa7
Compare
Member
Author
|
Accidentally added two commits meant for a later PR. dropped those commits and rebased on develop |
PastaPastaPasta
added a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 23, 2020
* Change litemode to disablegovernance, this makes it more clear what that flag actually does. Signed-off-by: pasta <[email protected]> * more fLiteMode to fDisableGovernance Signed-off-by: pasta <[email protected]> * handle -litemode being set Signed-off-by: pasta <[email protected]>
Member
Author
|
backported in #3670 |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 8, 2022
* Change litemode to disablegovernance, this makes it more clear what that flag actually does. Signed-off-by: pasta <[email protected]> * more fLiteMode to fDisableGovernance Signed-off-by: pasta <[email protected]> * handle -litemode being set Signed-off-by: pasta <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure if I should do the second commit manually, or if that'd happen automatically so I did it in a second commit so I can easily revert.reverted. I'm 90% sure.I think this makes
litemodea lot clearer and less confusing.TODO:
I need to add a check and throw an error if someone uses litemode or just interpret litemode the same as disablegovernance