Conversation
1068beb to
c701916
Compare
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
Signed-off-by: pasta <[email protected]>
c701916 to
1591ffc
Compare
|
Ready for review. This should make it easier for people to run a pruned node. If someone starts with -prune core will automatically try to set txindex and disablegovernance to the proper values, and will abort if not possible. It still shows the "governance validation is disabled" message but I made it a bit less scary. In the future I plan on changing it so that that warning will only pop up if it's a users first time in pruned mode, or if they aren't in pruned mode but have governance validation disabled. |
|
Pls see https://github.com/UdjinM6/dash/commits/pr3579:
|
|
I generally disagree with b2bb2649ee2e557adada59b975d620fcfef535bf because it is still important for pruned node operators to realize that they aren't doing FULL validation, only mostly full validation. I want in the future that warning to only pop up in case of first launch prune or launching w/o prune |
|
Well, then you need smth like 97e0fafcaa for example cause |
|
done |
|
Hmm... looks like more changes are needed to fix tests, pls see 4e9dfe90bb |
…ng a pruned node Co-authored-by: UdjinM6 <[email protected]>
|
commited suggestion |
|
cherry-picked |
* explicitly check that -disablegovernance is true for pruned mode. Signed-off-by: pasta <[email protected]> * try to set -disablegovernance and -txindex if pruned mode is enabled Signed-off-by: pasta <[email protected]> * Adjust InitWarning when governance validation is disabled Signed-off-by: pasta <[email protected]> * Check for deprecated -litemode earlier * Move -disablegovernance warning into AppInitParameterInteraction * Tweak -prune help text and a related comment in AppInitParameterInteraction * Ignore init warnings in blockchain.py * Adjust "governance validation disabled" warning depending on if running a pruned node Co-authored-by: UdjinM6 <[email protected]> * Skip init warnings in import-rescan.py and node_network_limited.py Co-authored-by: UdjinM6 <[email protected]>
|
backported in #3670 |
* explicitly check that -disablegovernance is true for pruned mode. Signed-off-by: pasta <[email protected]> * try to set -disablegovernance and -txindex if pruned mode is enabled Signed-off-by: pasta <[email protected]> * Adjust InitWarning when governance validation is disabled Signed-off-by: pasta <[email protected]> * Check for deprecated -litemode earlier * Move -disablegovernance warning into AppInitParameterInteraction * Tweak -prune help text and a related comment in AppInitParameterInteraction * Ignore init warnings in blockchain.py * Adjust "governance validation disabled" warning depending on if running a pruned node Co-authored-by: UdjinM6 <[email protected]> * Skip init warnings in import-rescan.py and node_network_limited.py Co-authored-by: UdjinM6 <[email protected]>
No description provided.