Merge #13007: test: Fix dangling wallet pointer in vpwallets#3666
Merge #13007: test: Fix dangling wallet pointer in vpwallets#3666UdjinM6 merged 2 commits intodashpay:developfrom
Conversation
The wallet should be removed after the dumpwallet() call otherwise it may lead to unepexted behaviour in other wallet tests since the wallet stays in vpwallets then.
|
Good find, however, please backport (modified) bitcoin#13007 instead |
hmm after a quick check im not sure if that makes sense? First, seems like we are already behind the code in that PR and even by backporting it "modified" the outcome would be the same it seems, no? |
Not quite, you'd also have to move another |
That would still not follow the bitcoin PR exactly, would it? I mean our |
PastaPastaPasta
changed the title
|
Please apply PastaPastaPasta@c9ab591, also changed title so that this is in git log showing up the backport even though due to the order of things this is kinda a backport and kinda not |
…ream Signed-off-by: pasta <[email protected]>
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
ACK, performed code review, and ran tests locally
UdjinM6
changed the title
…ashpay#3666) * test: Fix importwallet_rescan test The wallet should be removed after the dumpwallet() call otherwise it may lead to unepexted behaviour in other wallet tests since the wallet stays in vpwallets then. * tests: Change where RemoveWallet call is to be more in line with upstream Signed-off-by: pasta <[email protected]> Co-authored-by: pasta <[email protected]>
…ashpay#3666) * test: Fix importwallet_rescan test The wallet should be removed after the dumpwallet() call otherwise it may lead to unepexted behaviour in other wallet tests since the wallet stays in vpwallets then. * tests: Change where RemoveWallet call is to be more in line with upstream Signed-off-by: pasta <[email protected]> Co-authored-by: pasta <[email protected]>
3 participants
The wallet should be removed after the
dumpwallet()call otherwise itmay lead to unepexted behaviour in other wallet tests since the wallet
stays in
vpwalletsthen.