tests: Fix feature_llmq_simplepose.py and feature_llmq_signing.py#3781
Merged
UdjinM6 merged 7 commits intodashpay:developfrom Nov 19, 2020
Merged
tests: Fix feature_llmq_simplepose.py and feature_llmq_signing.py#3781UdjinM6 merged 7 commits intodashpay:developfrom
feature_llmq_simplepose.py and feature_llmq_signing.py#3781UdjinM6 merged 7 commits intodashpay:developfrom
Conversation
UdjinM6
force-pushed
the
fix_simplepose_test
branch
3 times, most recently
from
099a839 to
24d3698
Compare
Member
…ature_llmq_simplepose.py Bumping `50 * 60 + 1` should be enough, see https://github.com/dashpay/dash/blob/master/src/llmq/quorums_utils.cpp#L218-L222. Bumping `60 * 60 + 1` interferes with mnsync reset, see https://github.com/dashpay/dash/blob/master/src/masternode/masternode-sync.cpp#L112-L119.
…d" sets Needed for wait_for_masternode_probes in mine_quorum. Also, refactor and fix test_banning while at it.
UdjinM6
force-pushed
the
fix_simplepose_test
branch
from
24d3698 to
3e2efb7
Compare
Member
|
Restarting tests again on CI. If they pass, then I think this PR is probably good to go |
xdustinface
approved these changes
Nov 19, 2020
xdustinface
left a comment
xdustinface
left a comment
There was a problem hiding this comment.
utACK
nit: Title only refers to feature_llmq_simplepose.py but feature_llmq_signing.py is also affected here.
UdjinM6
changed the title
feature_llmq_simplepose.pyfeature_llmq_simplepose.py and feature_llmq_signing.py tests
UdjinM6
changed the title
feature_llmq_simplepose.py and feature_llmq_signing.py testsfeature_llmq_simplepose.py and feature_llmq_signing.py
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 12, 2022
…dashpay#3781) * tests: Use lower mocktime bump value to reset masternode probes in feature_llmq_simplepose.py Bumping `50 * 60 + 1` should be enough, see https://github.com/dashpay/dash/blob/master/src/llmq/quorums_utils.cpp#L218-L222. Bumping `60 * 60 + 1` interferes with mnsync reset, see https://github.com/dashpay/dash/blob/master/src/masternode/masternode-sync.cpp#L112-L119. * Fix expected connection count in llmq-signing.py and llmq-simplepose.py * Sleep a couple of seconds to let mn sync tick to happen * Move helper functions out of run_test * Let helper functions return expect_contribution_to_fail * No need to check for "punished" state in test_banning * Split mninfos in test_banning and mine_quorum into "online" and "valid" sets Needed for wait_for_masternode_probes in mine_quorum. Also, refactor and fix test_banning while at it.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pls see individual commits