rpc|test: Introduce "mnauth" RPC command to override masternode authentications by xdustinface · Pull Request #3930 · dashpay/dash

xdustinface · 2021-01-12T14:34:01Z

Allows to fake verified MN P2P connections. Something i need for an other test. If someone has a better idea how to archive this, let me know :)

Based on #3929

test/functional/rpc_mnauth.py

UdjinM6 · 2021-01-12T23:41:43Z

Code looks good but... why?

Something i need for another test.

Can you expand on this a bit pls?

xdustinface · 2021-01-13T00:11:50Z

Code looks good but... why?

Something i need for another test.

Can you expand on this a bit pls?

Im working on the QGETDATA/QDATA stuff which should be restricted to be used by masternodes only. At least that was the initial proposed idea from the document and normal nodes should anyway not care about it. And while i was writing tests i realised its not possible to write direct P2P tests if there is such a restriction. Soo, i see/saw the following options:

Not restrict it to masternodes only at all
Not restrict it to masternodes only for -regtest
Not restrict it to masternodes only if some command line parameter is set
Just fake MNAUTH for the testing P2P connection

I mean, actually i like having such a restriction but we could go with 1. if thats not a real concern (im not sure, just felt better to have it restricted..)? I guess the data should be cached then but it would make testing easier. Anyway, i don't like 2. and 3. because it wouldn't be a "full" test thats why i then took 4.

UdjinM6 · 2021-01-13T02:34:14Z

Ok, so you want to use mininode to send/receive these new messages but to do this you want dashd you are connected to to think that this mininode is a masternode, right? Can't you just reuse qwatch instead?

xdustinface · 2021-01-13T23:01:27Z

Can't you just reuse qwatch instead?

Hm, not really. Maybe i just don't get how you think that would help but what i basically need is that the connected node has a verified protx hash assigned. This branch is still WIP but See xdustinface@aea5dd7, xdustinface@03e9edb. Its already implemented with the fake mnauth in xdustinface@c287a46 but im totally open to drop the implementation and this PR if you come up with something else which makes more sense, let me know your thoughts :)

UdjinM6 · 2021-01-14T18:45:54Z

How about xdustinface@aea5dd7#r45968519 ?

xdustinface · 2021-01-19T06:11:26Z

@UdjinM6 Got it now with qwatch! I like the idea, see a55ac9a where i implemented it :) Buut, what do you think about adding both? I mean, the mnauth RPC command is basically useful for tests in general (depending on what we might do in the future with the MNAUTH for sure 🙈), no? And it at least helps in #3953 to somewhat test independent connections like here https://github.com/dashpay/dash/pull/3953/files#diff-2829e166b218f8d2acb7af7fd4e966be5cd8a21c9cc97f13fc29a8fa4a940dc6R274-R303. It's obviously not super important thing to test but it's one more 😄

src/rpc/misc.cpp

Co-authored-by: UdjinM6 <[email protected]>

UdjinM6

utACK

PastaPastaPasta

one nit, otherwise utACK

test/functional/rpc_mnauth.py

Co-authored-by: PastaPastaPasta <[email protected]>

UdjinM6

re-utACK

(tweaked PR title a bit)

PastaPastaPasta

utACK

…ntications (dashpay#3930) * rpc: Introduce "mnauth" RPC command to fake masternode authentications * test: Test "mnauth" RPC command * test: Add rpc_mnauth.py to BASE_SCRIPTS * Update src/rpc/misc.cpp Co-authored-by: UdjinM6 <[email protected]> * Update test/functional/rpc_mnauth.py Co-authored-by: PastaPastaPasta <[email protected]> Co-authored-by: UdjinM6 <[email protected]> Co-authored-by: PastaPastaPasta <[email protected]>

xdustinface added the RPC Some notable changes to RPC params/behaviour/descriptions label Jan 12, 2021

xdustinface added this to the 17 milestone Jan 12, 2021

xdustinface marked this pull request as draft January 12, 2021 14:34

xdustinface force-pushed the pr-rpc-mnauth branch 2 times, most recently from 8e734be to db1bb93 Compare January 12, 2021 15:23

PastaPastaPasta reviewed Jan 12, 2021

View reviewed changes

test/functional/rpc_mnauth.py Outdated Show resolved Hide resolved

xdustinface mentioned this pull request Jan 19, 2021

llmq|rpc|test|version: Implement P2P messages QGETDATA <-> QDATA #3953

Merged

xdustinface added 3 commits January 22, 2021 23:13

rpc: Introduce "mnauth" RPC command to fake masternode authentications

dc0abd3

test: Test "mnauth" RPC command

45a15fc

test: Add rpc_mnauth.py to BASE_SCRIPTS

a5860b0

xdustinface force-pushed the pr-rpc-mnauth branch from e1c11b3 to a5860b0 Compare January 22, 2021 22:20

xdustinface marked this pull request as ready for review January 22, 2021 22:21

xdustinface requested review from PastaPastaPasta and UdjinM6 January 22, 2021 22:22

xdustinface mentioned this pull request Jan 22, 2021

net|rpc: getpeerinfo - Add verified_pubkey_hash, fix a typo in verified_proregtx_hash docs #3929

Merged

UdjinM6 reviewed Jan 23, 2021

View reviewed changes

src/rpc/misc.cpp Outdated Show resolved Hide resolved

Update src/rpc/misc.cpp

9858622

Co-authored-by: UdjinM6 <[email protected]>

UdjinM6 previously approved these changes Jan 23, 2021

View reviewed changes

PastaPastaPasta previously approved these changes Jan 23, 2021

View reviewed changes

test/functional/rpc_mnauth.py Show resolved Hide resolved

Update test/functional/rpc_mnauth.py

514cc80

Co-authored-by: PastaPastaPasta <[email protected]>

xdustinface dismissed stale reviews from PastaPastaPasta and UdjinM6 via 514cc80 January 23, 2021 19:56

xdustinface requested review from PastaPastaPasta and UdjinM6 January 23, 2021 19:56

UdjinM6 changed the title ~~rpc|test: Introduce "mnauth" RPC command to fake masternode authentications~~ rpc|test: Introduce "mnauth" RPC command to override masternode authentications Jan 23, 2021

UdjinM6 approved these changes Jan 23, 2021

View reviewed changes

PastaPastaPasta approved these changes Jan 25, 2021

View reviewed changes

PastaPastaPasta merged commit ce3bcab into dashpay:develop Jan 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rpc|test: Introduce "mnauth" RPC command to override masternode authentications#3930

rpc|test: Introduce "mnauth" RPC command to override masternode authentications#3930
PastaPastaPasta merged 5 commits intodashpay:developfrom
xdustinface:pr-rpc-mnauth

xdustinface commented Jan 12, 2021

Uh oh!

Uh oh!

UdjinM6 commented Jan 12, 2021

Uh oh!

xdustinface commented Jan 13, 2021 •

edited

Loading

Uh oh!

UdjinM6 commented Jan 13, 2021 •

edited

Loading

Uh oh!

xdustinface commented Jan 13, 2021

Uh oh!

UdjinM6 commented Jan 14, 2021

Uh oh!

xdustinface commented Jan 19, 2021

Uh oh!

Uh oh!

UdjinM6 left a comment

Uh oh!

PastaPastaPasta left a comment

Uh oh!

Uh oh!

UdjinM6 left a comment

Uh oh!

PastaPastaPasta left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

xdustinface commented Jan 12, 2021

Uh oh!

Uh oh!

UdjinM6 commented Jan 12, 2021

Uh oh!

xdustinface commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xdustinface commented Jan 13, 2021

Uh oh!

UdjinM6 commented Jan 14, 2021

Uh oh!

xdustinface commented Jan 19, 2021

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xdustinface commented Jan 13, 2021 •

edited

Loading

UdjinM6 commented Jan 13, 2021 •

edited

Loading