llmq: Some refactoring in CChainLocksHandler::ProcessNewChainLock#3976
Merged
PastaPastaPasta merged 4 commits intodashpay:developfrom Feb 14, 2021
Merged
Conversation
|
cc1b476 really made me think if it actually makes any sense to have both |
|
Ping 👀 Any thoughts on dropping |
xdustinface
force-pushed
the
pr-llmq-refactor-processnewchainlock
branch
from
b6a37e3 to
75ede8a
Compare
Author
Member
|
Can you explain a51875f more? why are we dropping that? |
Author
See #3976 (comment) dash/src/llmq/quorums_chainlocks.cpp Line 634 in a51875f dash/src/llmq/quorums_chainlocks.cpp Line 120 in a51875f |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 1, 2022
…shpay#3976) * llmq: Drop InternalHasConflictingChainLock in ProcessNewChainLock * llmq: Directly use clsig.blockHash instead of copying it into msgHash * llmq: Reuse CInv(MSG_CLSIG, hash) * llmq: Add const in two places
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.