llmq|init|test: Add "mode" to -llmq-qvvec-sync parameter #4030
Merged
PastaPastaPasta merged 3 commits intodashpay:developfrom Mar 16, 2021
Merged
llmq|init|test: Add "mode" to -llmq-qvvec-sync parameter #4030PastaPastaPasta merged 3 commits intodashpay:developfrom
PastaPastaPasta merged 3 commits intodashpay:developfrom
Conversation
This changes the paramter from `-llmq-qvvec-sync=<quorum_name>` to `-llmq-qvvec-sync=<quorum_name:mode>` With the following definitions: - `quorum_name`: Internal name of the quorum type - `mode=0` - Sync always from all quorums of the type defined by `quorum_name` - `mode=1` - Sync only if member of any from all other quorum of the type defined by `quorum_name` `-llmq-qvvec-sync=llmq_100_67:0` To always request qvvec's from all `LLMQ_100_67`. `-llmq-qvvec-sync=llmq_100_67:1` Only request if type member. This means, if platform enables this on all MNs with `mode=0` we will have all nodes asking new quorum for their verification vector instead of only `24*100` at max.
5fc7a01 to
ba19b0c
Compare
|
Looks good 👍 How about UdjinM6@3564a81 ? |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 14, 2022
* llmq|init|test: Add "mode" to -llmq-qvvec-sync parameter This changes the paramter from `-llmq-qvvec-sync=<quorum_name>` to `-llmq-qvvec-sync=<quorum_name:mode>` With the following definitions: - `quorum_name`: Internal name of the quorum type - `mode=0` - Sync always from all quorums of the type defined by `quorum_name` - `mode=1` - Sync only if member of any from all other quorum of the type defined by `quorum_name` `-llmq-qvvec-sync=llmq_100_67:0` To always request qvvec's from all `LLMQ_100_67`. `-llmq-qvvec-sync=llmq_100_67:1` Only request if type member. This means, if platform enables this on all MNs with `mode=0` we will have all nodes asking new quorum for their verification vector instead of only `24*100` at max. * llmq: Adjust GetQuorumRecoveryStartOffset to use all MNs * Turn `QvvecSyncMode` into `enum class` Co-authored-by: UdjinM6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the paramter from
-llmq-qvvec-sync=<quorum_name>to-llmq-qvvec-sync=<quorum_name:mode>With the following definitions:
quorum_name: Internal name of the quorum typemode=0- Sync always from all quorums of the type defined byquorum_namemode=1- Sync only if member of any from all other quorum of the type defined byquorum_name-llmq-qvvec-sync=llmq_100_67:0To always request qvvec's from allLLMQ_100_67.-llmq-qvvec-sync=llmq_100_67:1Only request if type member.This means, if platform enables this on all MNs with
mode=0we willhave all nodes asking new quorum for their verification vector instead
of only
24*100at max.Follow up of #3964