partial #15842, merge #15849, #17342, #18710: Add local thread pool to CCheckQueue#4191
Merged
UdjinM6 merged 4 commits intodashpay:developfrom Jun 26, 2021
Merged
partial #15842, merge #15849, #17342, #18710: Add local thread pool to CCheckQueue#4191UdjinM6 merged 4 commits intodashpay:developfrom
UdjinM6 merged 4 commits intodashpay:developfrom
Conversation
kwvg
force-pushed
the
checkqueue
branch
5 times, most recently
from
2759ad0 to
3471350
Compare
kwvg
force-pushed
the
checkqueue
branch
2 times, most recently
from
d27e546 to
972af32
Compare
|
Looking at the diff now I think I messed up in my fixes a bit 🙈 , pls see UdjinM6@b071fe0 |
UdjinM6
reviewed
Jun 16, 2021
|
LGTM, pls squash c773696 into 187f473 (pr 15849) |
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Looks good, besides udjin squash and util stuff will require #4197 to be updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request presupposes the merger of #4190 intoThis pull request adds a local thread pool to CCheckQueue in preparation for more threading refactors.develop. Only the last four commits are meant to be reviewed.To actually comparecheckqueuewithtlocks, go hereMotivation
During initial preparation for bitcoin#18242 ("Add BIP324 encrypted p2p transport de-/serializer" by jonasschnelli) and the backporting of bitcoin@78c312c, a difference in class and function names were noticed and that in turn lead to a series of pull requests the lead us to this one.
The motivation is to reduce future merge conflicts when backporting pull requests from Bitcoin Core.
Contents
bitcoin#15849, bitcoin#17342, bitcoin#18710
Partials
bitcoin#15842
Disclosures