merge #16117, #18358, #17383, #21052, #14424, #15159, #14689, #14978, partial #16908, #14978, #13932: Auxillary Backports by kwvg · Pull Request #4229 · dashpay/dash

kwvg · 2021-07-02T07:52:59Z

Notes

~~bitcoin#20788 was originally having test failures and the lack of bitcoin#14624 was the cause. Tests run fine now.~~ Scrapped from this PR

PastaPastaPasta · 2021-07-04T15:52:51Z

Windows build borked

kwvg · 2021-07-09T16:07:39Z

Rebased and updated

EDIT: Pushed version without nanobench fix, re-pushed correct version

PastaPastaPasta · 2021-07-09T17:11:18Z

Not compiling

UdjinM6

16908: missing changes in test/functional/mempool_persist.py
18358: see ebc239029c6e464c38cc1010755cfc387cef9a41
20788: lots of changes from other PRs

src/bench/examples.cpp

src/util/time.h

src/net.cpp

src/netbase.cpp

PastaPastaPasta · 2021-07-13T16:50:09Z

functional tests borked

kwvg · 2021-07-15T17:57:58Z

Dunno what's happening with functional tests so bitcoin#16908 has been slimmed to the bare essentials needed for successive commits

PastaPastaPasta · 2021-07-16T00:35:38Z

Needs rebase

PastaPastaPasta · 2021-07-17T00:20:45Z

Tests are failing

github-actions · 2021-07-19T11:10:21Z

This pull request has conflicts, please rebase.

PastaPastaPasta · 2021-07-28T16:12:58Z

Marking as WIP due to the fact this PR has stalled. Please rebase, and mark as ready for review when this PR is RfR

…saction

…ono)

kwvg · 2021-08-05T14:17:07Z

Ready for review. Unrelated LLMQ tests failed

PastaPastaPasta · 2021-08-05T15:42:04Z

Test failures in feature_llmq_data_recovery.py are persistent. Does not seem unrelated.

kwvg · 2021-08-05T15:50:19Z

Test failures in feature_llmq_data_recovery.py are persistent. Does not seem unrelated.

~~Fixed, problem was isolated to 2659960~~ Apparently not.

EDIT: Integrated patches UdjinM6@781f6b9, UdjinM6@f37918a and UdjinM6@ada97ae by UdjinM6 have actually resolved the issue, thanks! 🙂

UdjinM6

Pls see https://github.com/UdjinM6/dash/commits/pr4229

… calls

…chemes

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

…g a P2PKH input

…UI code; related refactoring

UdjinM6

utACK

kwvg force-pushed the auxports branch from 2b6e2d7 to cce2966 Compare July 4, 2021 06:53

kwvg force-pushed the auxports branch 3 times, most recently from d47fe88 to f1ad65c Compare July 9, 2021 16:03

kwvg force-pushed the auxports branch from f1ad65c to cecac0a Compare July 9, 2021 18:13

UdjinM6 requested changes Jul 10, 2021

View reviewed changes

kwvg force-pushed the auxports branch 2 times, most recently from aacf67c to 408c9e8 Compare July 13, 2021 10:30

kwvg marked this pull request as draft July 13, 2021 10:35

kwvg force-pushed the auxports branch from 408c9e8 to 1767ac5 Compare July 13, 2021 14:26

kwvg marked this pull request as ready for review July 13, 2021 14:27

PastaPastaPasta added this to the 18 milestone Jul 14, 2021

kwvg force-pushed the auxports branch 2 times, most recently from da10617 to 9657ce4 Compare July 15, 2021 17:57

kwvg force-pushed the auxports branch from 9657ce4 to e63a2cb Compare July 16, 2021 14:15

github-actions bot added the needs rebase label Jul 19, 2021

PastaPastaPasta marked this pull request as draft July 28, 2021 16:13

kwvg force-pushed the auxports branch from e63a2cb to 81112fd Compare August 1, 2021 16:22

github-actions bot removed the needs rebase label Aug 1, 2021

kwvg changed the title ~~merge #14624, #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports~~ merge #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports Aug 1, 2021

kwvg force-pushed the auxports branch from 81112fd to a1f386c Compare August 5, 2021 10:18

kwvg added 4 commits August 5, 2021 16:13

partial bitcoin#14978: Factor BroadcastTransaction out of sendrawtran…

600c9f8

…saction

merge bitcoin#16117: Replace boost sleep with std sleep

cbc4a74

partial bitcoin#16908: txmempool: Make entry time type-safe (std::chr…

199a0f8

…ono)

merge bitcoin#18358: fix compilation with mingw-w64 7.0.0

1d5c176

kwvg force-pushed the auxports branch from b7185f5 to 7849922 Compare August 5, 2021 10:46

github-actions bot removed the needs rebase label Aug 5, 2021

kwvg force-pushed the auxports branch from 7849922 to 4a17435 Compare August 5, 2021 10:47

kwvg changed the title ~~merge #20788, #16117, #21052, partial #16908, #14978: Auxillary Backports~~ merge #16117, #18358, #17383, #21052, #14424, #15159, #14689, #14978, partial #16908, #14978, #13932: Auxillary Backports Aug 5, 2021

kwvg marked this pull request as ready for review August 5, 2021 14:16

kwvg force-pushed the auxports branch from 4a17435 to bf30d9a Compare August 5, 2021 15:47

UdjinM6 requested changes Aug 8, 2021

View reviewed changes

kwvg added 7 commits August 9, 2021 12:38

merge bitcoin#17383: Move consts to their correct translation units

91c8449

merge bitcoin#21052: Replace fs::unique_path with GetUniquePath(path)…

09ace18

… calls

merge bitcoin#14424: Stop requiring imported pubkey to sign non-PKH s…

a233e75

…chemes

merge bitcoin#15159: Remove lookup to UTXO set from GetTransaction

e8e48b3

No need for extra `-txindex` in Dash-specific tests, it's `true` by default

merge bitcoin#14689: Require a public key to be retrieved when signin…

5ae8e75

…g a P2PKH input

partial bitcoin#13932: Additional utility RPCs for PSBT

419bcd3

merge bitcoin#14978: Factor out PSBT utilities from RPCs for use in G…

5229347

…UI code; related refactoring

kwvg force-pushed the auxports branch from bf30d9a to 5229347 Compare August 9, 2021 07:08

kwvg requested a review from UdjinM6 August 9, 2021 07:09

UdjinM6 approved these changes Aug 9, 2021

View reviewed changes

UdjinM6 requested a review from PastaPastaPasta August 10, 2021 16:27

UdjinM6 merged commit 7aebf15 into dashpay:develop Aug 10, 2021

UdjinM6 added the RPC Some notable changes to RPC params/behaviour/descriptions label Aug 19, 2021

dzutto mentioned this pull request Sep 11, 2021

Merge #14955: Switch all RNG code to the built-in PRNG #4411

Merged

dzutto mentioned this pull request Sep 24, 2021

Merge 0.18 PRs: #14268, #15408, #14094, #14935 and #14969 #4453

Merged

kwvg deleted the auxports branch July 18, 2023 11:39

Conversation

kwvg commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Uh oh!

PastaPastaPasta commented Jul 4, 2021

Uh oh!

kwvg commented Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PastaPastaPasta commented Jul 9, 2021

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PastaPastaPasta commented Jul 13, 2021

Uh oh!

kwvg commented Jul 15, 2021

Uh oh!

PastaPastaPasta commented Jul 16, 2021

Uh oh!

PastaPastaPasta commented Jul 17, 2021

Uh oh!

github-actions bot commented Jul 19, 2021

Uh oh!

PastaPastaPasta commented Jul 28, 2021

Uh oh!

kwvg commented Aug 5, 2021

Uh oh!

PastaPastaPasta commented Aug 5, 2021

Uh oh!

kwvg commented Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kwvg commented Jul 2, 2021 •

edited

Loading

kwvg commented Jul 9, 2021 •

edited

Loading

kwvg commented Aug 5, 2021 •

edited

Loading