merge bitcoin#15043, #15295, #15399, #17452, #16338, #15504, #17076, #17069, #17018: fuzzing#4312
Merged
PastaPastaPasta merged 17 commits intodashpay:developfrom Aug 11, 2021
Merged
merge bitcoin#15043, #15295, #15399, #17452, #16338, #15504, #17076, #17069, #17018: fuzzing#4312PastaPastaPasta merged 17 commits intodashpay:developfrom
PastaPastaPasta merged 17 commits intodashpay:developfrom
Conversation
kwvg
force-pushed
the
fuzz
branch
4 times, most recently
from
ff7a148 to
27ec275
Compare
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
partial review, almost everything looks good
UdjinM6
requested changes
Aug 6, 2021
|
This pull request has conflicts, please rebase. |
Member
|
See https://github.com/PastaPastaPasta/dash/tree/pr_4312 for my rebased branch. (pretty trivial rebase) |
UdjinM6
requested changes
Aug 10, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
- 15295 is partial I think
- linter complains "Good job!" :) https://gitlab.com/dashpay/dash/-/jobs/1486652462#L57
- see below
.travis.yml
Outdated
Comment on lines
285
to
295
There was a problem hiding this comment.
would be nice to have a Gitlab CI job similar to this to make sure things work as expected
…ardTx(...) and other CTransaction related functions
…Handle only when needed
… Test round-trip equality where possible
Contains only patch applied on src/Makefile.am from 9eaeb7f needed to fix builds
|
linter still complains |
Collaborator
Author
|
Read the "Good Job", didn't read the "remove from file", resolved! |
PastaPastaPasta
approved these changes
Aug 11, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
src/test/test_dash_fuzzy.cpp
Outdated
| @@ -1,11 +1,7 @@ | |||
| // Copyright (c) 2009-2015 The Bitcoin Core developers | |||
| // Copyright (c) 2009-2018 The Bitcoin Core developers | |||
Member
There was a problem hiding this comment.
nit: this shouldn't have been changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.