merge bitcoin#16787, #17474, #17687, #18165, #18877, #18960, #19010, #19044, #19070: block filters#4355
Merged
UdjinM6 merged 9 commits intodashpay:developfrom Sep 21, 2021
Merged
Conversation
kwvg
changed the title
Member
|
linter + both tests are unhappy |
Collaborator
Author
|
It's a work in progress |
Member
|
Marked as draft |
|
This pull request has conflicts, please rebase. |
Member
|
Please rename all commits to begin with "Merge" |
PastaPastaPasta
requested changes
Sep 17, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
LGTM, besides one thing and a comment
src/net_processing.h
Outdated
Member
There was a problem hiding this comment.
We should consider what all of these defaults should be, like should normal nodes be serving bloom filters by default for example?
…lterindex twice
…to a shared serviceFlagToStr function
…DE_COMPACT_FILTERS
PastaPastaPasta
approved these changes
Sep 19, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.