merge bitcoin#14150, #14477, #14646, #14667, #14886, #14565, #14491, #15368: descriptors#4494
Merged
UdjinM6 merged 12 commits intodashpay:developfrom Nov 1, 2021
Merged
merge bitcoin#14150, #14477, #14646, #14667, #14886, #14565, #14491, #15368: descriptors#4494UdjinM6 merged 12 commits intodashpay:developfrom
UdjinM6 merged 12 commits intodashpay:developfrom
Conversation
kwvg
changed the title
kwvg
force-pushed
the
descaddr
branch
2 times, most recently
from
7180e07 to
4651c6a
Compare
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
descaddr
branch
2 times, most recently
from
0d19f75 to
076d87c
Compare
UdjinM6
requested changes
Oct 26, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
missing few doc/release-notes-xxxxx.md files (which is probably ok) + see below
|
Looks good. 15749 should probably be marked as "partial" (missing changes to the code introduced in 14021). |
PastaPastaPasta
approved these changes
Oct 29, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
(waiting for Merge bitcoin#14726: Use RPCHelpMan for all RPCs #4492 merger)