merge bitcoin #13013, #14908, #14906: Make explicit CMutableTransaction -> CTransaction conversion#4504
Merged
UdjinM6 merged 3 commits intodashpay:developfrom Oct 13, 2021
Merged
Conversation
Member
|
Please make these separate commits |
Collaborator
Author
|
I discovered bitcoin#14908 after pushing this branch, I did all the changes manually. Just mentioned it for completeness but otherwise did those changes by hand |
Member
|
They really should be in separate commits, both for git cleanliness sake, and for the sake of my script. There should only be one backport per commit |
Collaborator
Author
|
Done |
PastaPastaPasta
requested changes
Oct 11, 2021
PastaPastaPasta
requested changes
Oct 13, 2021
PastaPastaPasta
approved these changes
Oct 13, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
UdjinM6
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.