merge bitcoin#13219...#15779: benchmarks#4511
Merged
UdjinM6 merged 10 commits intodashpay:developfrom Oct 25, 2021
Merged
Conversation
|
This pull request has conflicts, please rebase. |
…g pcoinsdbview, pcoinsTip or pblocktree
UdjinM6
requested changes
Oct 25, 2021
UdjinM6
reviewed
Oct 25, 2021
|
Not sure how you do this but Gitlab fails to pick and build this branch again... local ci is here https://gitlab.com/UdjinM6/dash/-/pipelines/395050276 |
Collaborator
Author
|
Yeah, seems to be a random quirk, maybe it didn't go through or it isn't a fan of frequent force-pushes, I dunno but it is throwing a wrench into things. Thanks for the personal CI run! |
PastaPastaPasta
approved these changes
Oct 25, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merge via merge commit
Seems correct to me, plus it's only benchmarks :D
This was referenced Oct 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes
CTxDestinationwithin Dash as of now, causing an assertion failure in the middle of running benchmarks, hence the substitution with a RegTest B58 P2PKH address.Checklist (Part 1)
Checklist (Part 2)
refactor: test/bench: dedup Build{Crediting,Spending}Transaction() bitcoin/bitcoin#17183
Add new mempool benchmarks for a complex pool bitcoin/bitcoin#17292
More information is available at merge bitcoin#16540...#17542: benchmarks (part 2) #4702