bitcoin#8365: Treat high-sigop transactions as larger rather than rejecting them#4562
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Nov 8, 2021
Merged
bitcoin#8365: Treat high-sigop transactions as larger rather than rejecting them#4562UdjinM6 merged 1 commit intodashpay:developfrom
UdjinM6 merged 1 commit intodashpay:developfrom
Conversation
kwvg
requested review from
PastaPastaPasta and
UdjinM6
and removed request for
UdjinM6
PastaPastaPasta
previously approved these changes
Nov 2, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
LGTM, but I'm not positive that this is correct / ideal. Waiting for Udjin
utACK for squash merge
UdjinM6
requested changes
Nov 3, 2021
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
I don't think we can just drop nSigOps > nSize / nBytesPerSigOp and tweak help text without implementing actual changes it describes, that feels wrong. Moreover, going through 8365 discussion it looks like it's a bugfix and it makes sense to backport it imo. I guess we missed it due to a very segwit-only looking code but it's not segwit-only actually. Also, I found a couple of related bugs (in test and bench) while trying to make it work. Anyway, pls see https://github.com/UdjinM6/dash/commits/pr4562
…an rejecting them
PastaPastaPasta
approved these changes
Nov 4, 2021
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
UtACK for squash merge
UdjinM6
changed the title
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
…an rejecting them (dashpay#4562)
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 24, 2022
…an rejecting them (dashpay#4562)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split as #4562 (this PR) and #4560 for ease of review