Merged
Conversation
PastaPastaPasta
previously approved these changes
Dec 1, 2021
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
UdjinM6
requested changes
Dec 1, 2021
879c57a to
6675be6
Compare
499149b to
2065c3d
Compare
Member
|
please apply PastaPastaPasta@5c00a09 Then LGTM |
a7c58a0 to
27aa4bc
Compare
Author
Changes applied |
Author
|
@UdjinM6 and @PastaPastaPasta please re-approve so that it can be merged. |
PastaPastaPasta
requested changes
Dec 9, 2021
07de45b to
aaa71fb
Compare
PastaPastaPasta
approved these changes
Dec 11, 2021
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
5 tasks
PastaPastaPasta
added a commit
that referenced
this pull request
Oct 18, 2023
Implementation EHF mechanism, part 4. Previous changes are: - #4577 - #5505 - #5469 ## Issue being fixed or feature implemented Currently MN_RR is activated automatically by soft-fork activation after v20 is activated. It is not flexible enough, because platform may not be released by that time yet or in opposite it can be too long to wait. Also, any signal of EHF requires manual actions from MN owners to sign EHF signal - it is automated here. ## What was done? New spork `SPORK_24_MN_RR_READY`; new EHF manager that sign EHF signals semi-automatically without manual actions; and send transaction with EHF signal when signal is signed to network. Updated rpc `getblockchaininfo` to return information about of EHF activated forks. Fixed function `IsTxSafeForMining` in chainlock's handler to skip transactions without inputs (empty `vin`). ## How Has This Been Tested? Run unit/functional tests. Some tests have been updated due to new way of MN_RR activation: `feature_asset_locks.py`, `feature_mnehf.py`, `feature_llmq_evo.py` and unit test `block_reward_reallocation_tests`. ## Breaking Changes New way of MN_RR activation. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ --------- Co-authored-by: UdjinM6 <[email protected]> Co-authored-by: PastaPastaPasta <[email protected]>
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 7, 2023
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to implement #4533.