implemented changes suggested PR#4351 by daharkan · Pull Request #4629 · dashpay/dash

daharkan · 2021-12-19T14:13:18Z

created new slot GovernanceList::openUrl(), not using Proposal::openUrl() since we need to show a pop-up message box and we need a QWidget parent.

Implemented TextAlignmentRole values for ProposalModel::data.

PastaPastaPasta · 2021-12-20T16:49:08Z

Payments remaining calculation is wrong. (Also should probably have tests associated with it.)

github-actions · 2021-12-30T19:04:59Z

This Pull Request may conflict if the Pull Requests below are merged first.

#4649
conflictable files: src/qt/governancelist.cpp,src/qt/governancelist.h

proposaltests added for testing paymentRemaining calculation

PastaPastaPasta · 2022-01-02T21:05:01Z

src/qt/test/proposaltests.cpp

@@ -0,0 +1,21 @@
+#include "proposaltests.h"


you need add copyright

PastaPastaPasta · 2022-01-02T21:09:33Z

src/qt/test/proposaltests.h

@@ -0,0 +1,15 @@
+#ifndef PROPOSALTESTS_H


PastaPastaPasta · 2022-01-02T21:22:33Z

src/qt/test/proposaltests.cpp

+    proposal.m_currentDate = QDateTime(QDate(2022, 1, 2), QTime(12, 00));
+    proposal.m_endDate = QDateTime(QDate(2022, 2, 9), QTime(12, 00));
+    QVERIFY( proposal.paymentRemaining() == 1) ;
+
+    proposal.m_currentDate = QDateTime(QDate(2022, 1, 2), QTime(12, 00));
+    proposal.m_endDate = QDateTime(QDate(2022, 3, 5), QTime(12, 00));
+    QVERIFY( proposal.paymentRemaining() == 2);
+
+    proposal.m_currentDate = QDateTime(QDate(2022, 1, 2), QTime(12, 00));
+    proposal.m_endDate = QDateTime(QDate(2022, 4, 10), QTime(12, 00));
+    QVERIFY( proposal.paymentRemaining() == 3);


should test the exact edges, and preferably de-duplicate this code smth like

const auto& check_paymentRemaining = [&proposal](const auto& begin, const auto& end, int expected) { proposal.m_currentDate = begin; proposal.m_endDate = end; QVERIFY( proposal.paymentRemaining() == expected) ; }

Also, I think there may be a bug here... the currentDate and endDate shouldn't be enough to calculate payments remaining.. I think you also need to know when the last superblock was. @UdjinM6 maybe @thephez, what should the calculation be to determine payments remaining?

Yes, it doesn't seem possible to fully evaluate without comparing against superblock times. I'm not sure what the full calculation would be, but it should be available somewhere in either Core or Sentinel. Perhaps @UdjinM6 has a reference? 🤞 DMT definitely does this calc also since it displays this info. My guess would be that it happens somewhere in here, but that's a long file.

Also, since the proposal start/end are defined as timestamps while the superblocks are based on block heights, it's not a precise calculation (i.e. it's impacted by variations in block time).

Should it be something like this at line # 260 at here ?

payment_remaining = payment_cycles - cur_cycle

payment_cycles = int((end_sb - start_sb) / cycle_blocks) + 1 # calculate number of payment-months that passed already for the proposal if start_sb > last_superblock: cur_cycle = 0 else: cur_cycle = int(((last_superblock - start_sb) / cycle_blocks)) + 1`

PastaPastaPasta · 2022-01-02T21:26:20Z

src/qt/governancelist.cpp

+
+void GovernanceList::openUrl()
+{
+    QAction *openProposalUrl = qobject_cast<QAction*>(sender());


ptr should go on the type

Suggested change

QAction *openProposalUrl = qobject_cast<QAction*>(sender());

QAction* openProposalUrl = qobject_cast<QAction*>(sender());

PastaPastaPasta · 2022-01-02T21:30:26Z

Also please see https://github.com/dashpay/dash/runs/4686124022?check_suite_focus=true

Munkybooty · 2022-01-03T06:54:36Z

src/qt/governancelist.cpp

+            return proposal->GetNoCount();
+        case Column::ABSOLUTE_YES:
+            return proposal->GetAbsoluteYesCount();
+        case Column::ABSTEIN_COUNT:


Should be ABSTAIN

Munkybooty · 2022-01-03T06:55:02Z

src/qt/governancelist.cpp

+            return proposal->GetNoCount();
+        case Column::ABSOLUTE_YES:
+            return proposal->GetAbsoluteYesCount();
+        case Column::ABSTEIN_COUNT:


Should be ABSTAIN

Munkybooty · 2022-01-03T06:55:18Z

src/qt/governancelist.cpp

+            return Qt::AlignCenter;
+        case Column::ABSOLUTE_YES:
+            return Qt::AlignCenter;
+        case Column::ABSTEIN_COUNT:


Should be ABSTAIN

Munkybooty · 2022-01-03T06:55:49Z

src/qt/governancelist.cpp

+    case Column::ABSTEIN_COUNT:
+        return "Abstein";


Should be ABSTAIN and return "Abstain"

Munkybooty · 2022-01-03T06:56:03Z

src/qt/governancelist.cpp

+        return 180;
+    case Column::YES_COUNT:
+    case Column::NO_COUNT:
+    case Column::ABSTEIN_COUNT:


Should be ABSTAIN

Munkybooty · 2022-01-03T06:56:09Z

src/qt/governancelist.h

        IS_ACTIVE,
+        YES_COUNT,
+        NO_COUNT,
+        ABSTEIN_COUNT,


Should be ABSTAIN

github-actions · 2022-02-15T16:33:46Z

This pull request has conflicts, please rebase.

DashCoreAutoGuix · 2025-07-28T16:49:24Z

❌ Backport Verification - CATASTROPHIC FAILURE

Original Bitcoin commit: 97ee866549
Reviewed commit hash: 733b2b9bfb-verify-$(date +%s)

Critical violations detected:

1. Complete Backport Mismatch 🚨

Bitcoin PR#4351: Implements REST UTXOS functionality (getutxos REST command)
This Dash PR: Implements governance UI improvements (completely unrelated)
Verdict: Wrong functionality entirely - this is not a backport at all

2. Size Explosion (Inverse) 🚨

Bitcoin changes: 433 lines across 4 files (REST implementation)
Dash changes: 5 lines in governance UI code
Size ratio: 0.0% - essentially no relevant backport content

3. File Operation Mismatch 🚨

Bitcoin modifies: qa/rpc-tests/rest.py, src/rest.cpp, src/rpcserver.cpp, src/rpcserver.h
Dash modifies: src/qt/governancelist.cpp, src/qt/test/proposaltests.cpp (completely different files)
Missing files: All 4 Bitcoin files are absent

4. Intent Violation 🚨

Bitcoin intent: Add UTXO querying via REST API with binary input/output (Bip64)
Dash implementation: Add UI tests and popup messages for governance proposals
Relationship: None - completely different features

Analysis Summary

This PR appears to have been incorrectly titled and associated with Bitcoin PR#4351. The actual changes implement Dash-specific governance UI improvements that have no relationship to the Bitcoin REST functionality that should have been backported.

Bitcoin PR#4351 should implement:

UTXO querying over REST (/rest/getutxos/ endpoint)
Binary input/output format as per Bip64
REST API tests in qa/rpc-tests/rest.py
Core REST functionality in src/rest.cpp

This PR instead implements:

Governance proposal UI enhancements
Test additions for proposal functionality
UI alignment and popup message improvements

❌ Comparison Analysis

Bitcoin commit 97ee866:

qa/rpc-tests/rest.py | 186 +++++++++++++++++++++++++++++++++++++--
src/rest.cpp         | 244 +++++++++++++++++++++++++++++++++++++++++++++++----
src/rpcserver.cpp    |   2 +-
src/rpcserver.h      |   1 +
4 files changed, 407 insertions(+), 26 deletions(-)

Dash PR #4629:

src/qt/test/proposaltests.cpp | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

No overlap in functionality, files, or intent.

Auto-Close Justification

This PR meets ALL catastrophic failure criteria:

✅ Multiple Auto-Reject Conditions (4+ violations)
✅ Fundamental Intent Violation (completely different functionality)
✅ File Operation Mismatch (no overlapping files)
✅ Size Mismatch (0.0% implementation of intended changes)

This PR has been automatically closed. Please create a new PR with the actual Bitcoin PR#4351 REST functionality backport.

DashCoreAutoGuix · 2025-07-28T16:49:31Z

Automatically closed due to catastrophic validation failures. This PR implements Dash governance UI changes instead of the intended Bitcoin REST functionality backport. Please see the detailed analysis above and create a new PR with the actual Bitcoin PR#4351 backport implementation (REST UTXOS functionality).

daharkan added 2 commits December 19, 2021 17:07

implemented changes suggested PR#4351

6ad6794

new line removed

babc1de

github-actions bot mentioned this pull request Dec 30, 2021

Avoid using raw pointers in GetAllNewerThan results #4649

Merged

daharkan added 2 commits January 2, 2022 19:16

paymentRemaining calculation fixed

79d8355

proposaltests added for testing paymentRemaining calculation

added new test

733b2b9

PastaPastaPasta requested changes Jan 2, 2022

View reviewed changes

Munkybooty suggested changes Jan 3, 2022

View reviewed changes

github-actions bot added the needs rebase label Feb 15, 2022

	QAction openProposalUrl = qobject_cast<QAction>(sender());
	QAction* openProposalUrl = qobject_cast<QAction*>(sender());

Conversation

daharkan commented Dec 19, 2021

Uh oh!

PastaPastaPasta commented Dec 20, 2021

Uh oh!

github-actions bot commented Dec 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daharkan Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta commented Jan 2, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 15, 2022

Uh oh!

DashCoreAutoGuix commented Jul 28, 2025

❌ Backport Verification - CATASTROPHIC FAILURE

Critical violations detected:

1. Complete Backport Mismatch 🚨

2. Size Explosion (Inverse) 🚨

3. File Operation Mismatch 🚨

4. Intent Violation 🚨

Analysis Summary

Auto-Close Justification

Uh oh!

DashCoreAutoGuix commented Jul 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

daharkan Jan 3, 2022 •

edited

Loading