Reduce MIN_STANDARD_TX_SIZE to 83 bytes#4668
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Jan 20, 2022
Merged
Conversation
P2SH output is 2 bytes smaller than P2PKH
PastaPastaPasta
approved these changes
Jan 19, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Apr 19, 2022
P2SH output is 2 bytes smaller than P2PKH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limit was introduced in 906be7e and bumped to 85 bytes in 11aa04e. Switching from P2WKH to P2PKH is how we dashify things usually, so everything looked ok. But the reason P2PWKH was picked in the original PR was that it was the smallest possible one. With this in mind we should really be switching from P2WKH to P2SH here since it's 2 bytes smaller than P2PKH.
This bug is the reason why
p2p_invalid_tx.pyfails in #4612 atm.