Merged
Conversation
We no longer pass cmd line params to qt after 16578 backport. Use cmd line params stored in args manager instead.
PastaPastaPasta
requested changes
Mar 4, 2022
src/qt/rpcconsole.cpp
Outdated
Comment on lines
+861
to
+862
| for (const auto& key_pair : gArgs.GetCommandLineArgs()) { | ||
| for (const auto& value : key_pair.second) { |
Member
There was a problem hiding this comment.
nit, please use structured binding and name key_pair.first and key_pair.second
PastaPastaPasta
approved these changes
Mar 5, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
Collaborator
|
Ahah, this probably explains why my attempt to reindex a devnet recently resulted in a mainnet reindex 🤦♂️ |
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Nov 9, 2023
* store cmd line params in args manager * qt: repair Repair We no longer pass cmd line params to qt after 16578 backport. Use cmd line params stored in args manager instead. * use structured binding * handle empty args correctly
gades
pushed a commit
to piratecash/pirate
that referenced
this pull request
Dec 9, 2023
* store cmd line params in args manager * qt: repair Repair We no longer pass cmd line params to qt after 16578 backport. Use cmd line params stored in args manager instead. * use structured binding * handle empty args correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was broken by 7b8ddda. To reproduce the issue: open testnet wallet (via
--testnetin cmd line), open Repair tab, click "Upgrade wallet" (the less harmful one) - wallet restarts with-upgradewalletbut no--testnetso it's a mainnet wallet now.