tests: basic functional tests for CoinJoin#4730
Merged
PastaPastaPasta merged 8 commits intodashpay:developfrom Jun 11, 2022
Merged
tests: basic functional tests for CoinJoin#4730PastaPastaPasta merged 8 commits intodashpay:developfrom
PastaPastaPasta merged 8 commits intodashpay:developfrom
Conversation
|
This pull request has conflicts, please rebase. |
Munkybooty
force-pushed
the
clientFuncTests
branch
from
96cc6ca to
3e57902
Compare
|
This pull request has conflicts, please rebase. |
Munkybooty
force-pushed
the
clientFuncTests
branch
from
3e57902 to
3abbc97
Compare
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 1, 2022
2862b56 [tests] remove redundant univalue_tests.cpp (John Newbery) Pull request description: univalue unit tests were added in dashpay#4730 , and exist at `/src/test/univalue_tests.cpp` (outside the univalue tree). That test was brought into the univalue repository in bitcoin-core/univalue-subtree#4 , which was pulled into the github repository in bitcoin#11420. That means that the univalue test exists in two places: 1. `/src/test/univalue_tests.cpp` 2. `/src/univalue/test/object.cpp` (2) is a strict superset of (1). It adds some macros to work around boost not being a univalue dependency, and adds a few extra lines of test. Therefore remove `/src/test/univalue_tests.cpp` Tree-SHA512: 3747b10bbf62e9f12363905488b29945ad559ddca68c5c03d8a362de612a51f408f41a04d3712c6889bfc1632fb1a5fa0d7df0fbf02c322b3981a6d698f501b0
Munkybooty
force-pushed
the
clientFuncTests
branch
from
b5d2f27 to
9051981
Compare
Munkybooty
force-pushed
the
clientFuncTests
branch
from
9051981 to
dbd64c0
Compare
Munkybooty
force-pushed
the
clientFuncTests
branch
from
dbd64c0 to
dfe64f9
Compare
UdjinM6
requested changes
Jun 7, 2022
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
no need for nVersion < MIN_PEER_PROTO_VERSION check, such peers are disconnected right away and should never get this far
UdjinM6
requested changes
Jun 8, 2022
PastaPastaPasta
changed the title
PastaPastaPasta
approved these changes
Jun 11, 2022
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to be opening this as a draft because i am not finished but it will probably be better to have more eyes on it than me continuously roadblocking myself at the moment