docs: Release notes for BLS upgrade#5137
Merged
PastaPastaPasta merged 14 commits intodashpay:developfrom Feb 6, 2023
ogabrielides:bls_upgrade_release_notes
Merged
docs: Release notes for BLS upgrade#5137PastaPastaPasta merged 14 commits intodashpay:developfrom ogabrielides:bls_upgrade_release_notes
PastaPastaPasta merged 14 commits intodashpay:developfrom
ogabrielides:bls_upgrade_release_notes
Conversation
thephez
requested changes
Jan 4, 2023
Collaborator
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
Some small suggestions...
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
thephez
reviewed
Jan 5, 2023
Collaborator
thephez
left a comment
thephez
left a comment
There was a problem hiding this comment.
Looks okay to me now 👍 It would be nice to have a small mention of why this upgrade was made or what benefit it provides.
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Jan 20, 2023
## Issue being fixed or feature implemented Added the missing rpc in `protx` help. Release notes can be found in #5137 ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **For repository code-owners and collaborators only** - [x] I have assigned this pull request to a milestone Co-authored-by: thephez <[email protected]>
thephez
reviewed
Jan 26, 2023
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Author
|
@PastaPastaPasta @UdjinM6 Could you review this please? |
PastaPastaPasta
approved these changes
Feb 4, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only