backport: Merge bitcoin#19237,19378,18422#5143
Merged
PastaPastaPasta merged 3 commits intodashpay:developfrom Apr 15, 2023
Merged
backport: Merge bitcoin#19237,19378,18422#5143PastaPastaPasta merged 3 commits intodashpay:developfrom
PastaPastaPasta merged 3 commits intodashpay:developfrom
Conversation
vijaydasmp
changed the title
vijaydasmp
changed the title
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp21_10
branch
2 times, most recently
from
0a2b7b7 to
50e3698
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp21_10
branch
4 times, most recently
from
a13864b to
8ac20b3
Compare
|
This pull request has conflicts, please rebase. |
vijaydasmp
force-pushed
the
bp21_10
branch
2 times, most recently
from
ff89cad to
1d104d4
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp21_10
branch
6 times, most recently
from
afbd704 to
ef47ed9
Compare
vijaydasmp
changed the title
UdjinM6
requested changes
Feb 27, 2023
vijaydasmp
force-pushed
the
bp21_10
branch
2 times, most recently
from
56d2eb7 to
f9eb5df
Compare
vijaydasmp
changed the title
Author
|
Hello @PastaPastaPasta , please review |
added 3 commits
April 15, 2023 12:14
37ae687 Add tests for CPubKey serialization/unserialization (Elichai Turkel) 9b8907f Check size after Unserializing CPubKey (Elichai Turkel) Pull request description: Found by practicalswift, closes bitcoin#19235 Currently all the public API(except the pointer-like API) in CPubKey that sets/constructs a pubkey goes through `CPubKey::Set` which checks if that the length and size match and if not invalidates the key. This adds the same check to `CPubKey::Unserialize`, sadly I don't see an easy way to just push this to the existing checks in `CPubKey::Set` but it's only a simple condition. The problem with not invalidating is that if you write a pubkey like: `{0x02,0x00}` it will think the actual length is 33(because of `size()`) and will access uninitialized memory if you call any of the functions on CPubKey. ACKs for top commit: practicalswift: re-ACK 37ae687 jonatack: Code review re-ACK 37ae687 per `git diff eab8ee3 37ae687` only change since last review at eab8ee3 is passing the `pubkey` param by reference to const instead of by value in `src/test/key_tests.cpp::CmpSerializationPubkey` MarcoFalke: ACK 37ae687 Tree-SHA512: 30173755555dfc76d6263fb6a59f41be36049ffae7b4e1b92b922d668f5e5e2331f7374d5fa10d5d59fc53020d2966156905ffcfa8b8129c1f6d0ca062174ff1
…ed_transactions 1307686 refactor: Use Mutex type for g_cs_recent_confirmed_transactions (Hennadii Stepanov) Pull request description: No need the `RecursiveMutex` type for the `g_cs_recent_confirmed_transactions`. Related to bitcoin#19303. ACKs for top commit: MarcoFalke: ACK 1307686 vasild: ACK 1307686 Tree-SHA512: 67f1be10c80ec18d0f80b9f5036e5a20986314da9b9364ef4e193ad1d9f3f4c8e4c2e16253ca79d649ff602d5b8c2aff58d7dd1085841afb760479a4875cffbe
…valScript code to EvalChecksig 14e8cf9 [consensus] MOVEONLY: Move single-sig checking EvalScript code to EvalChecksig (Pieter Wuille) Pull request description: This is another small refactor pulled out of the Schnorr/Taproot PR bitcoin#17977. This is in preparation for adding different signature verification rules, specifically tapscript (BIP 342), which interprets opcode 0xac and 0xad as Schnorr signature verifications. ACKs for top commit: sipa: ACK 14e8cf9, verified move-only. MarcoFalke: ACK 14e8cf9, reviewed with "git show 14e8cf9 --color-moved=dimmed-zebra --color-moved-ws=ignore-all-space -W" 👆 fjahr: Code-review ACK 14e8cf9, verified that it's move-only. instagibbs: code review ACK bitcoin@14e8cf9, verified move-only theStack: Code-Review ACK bitcoin@14e8cf9 jonatack: ACK 14e8cf9 Tree-SHA512: af2efce9ae39d5ec01db5b9ef0ff383fe252ef5f33b3483927308ae17d91a619266cb45951f32ea1ce54807a4c0f052bcdefb47e244465d3a726393221c227b1
PastaPastaPasta
force-pushed
the
bp21_10
branch
from
28313eb to
a8c7d72
Compare
PastaPastaPasta
approved these changes
Apr 15, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.