backport: merge bitcoin#19806, #21582, #21584, #21270, #21789, #22415, #21525, #21592 (assumeutxo project backports, part 3)#5236
Conversation
kwvg
changed the title
kwvg
force-pushed
the
utxo_assume
branch
12 times, most recently
from
7483db9 to
4534f62
Compare
kwvg
force-pushed
the
utxo_assume
branch
2 times, most recently
from
34c07a7 to
ba8bc46
Compare
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
utxo_assume
branch
3 times, most recently
from
8dc73c0 to
f965d97
Compare
|
This pull request has conflicts, please rebase. |
kwvg
force-pushed
the
utxo_assume
branch
2 times, most recently
from
798ca0f to
ac60187
Compare
src/chainparams.cpp
Outdated
There was a problem hiding this comment.
how did you get these values?
There was a problem hiding this comment.
The expected value is generated through the following call chain that starts from validation_chainstatemanager_tests.cpp and ends with a hash comparison check against hardcoded assumeutxo hashes:
CreateAndActivateUTXOSnapshot > ActivateSnapshot > PopulateAndValidateSnapshot
It's just a matter of running ./src/test/test_dash -t validation_chainstatemanager_tests -- DEBUG_LOG_OUT | grep bad and taking the expected hash. Be careful not the take the expected hash generated from one of the tests where the results are expected to be a validation failure.
The hash value for height 210 was calculated similarly by modifying the test to mine 100 more blocks.
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
rebase looks correct; merging to avoid further conflicts
4 participants
Additional Notes