fix: specify expected_stderr within restart_node in feature_pruning.py#5324
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Apr 16, 2023
Merged
fix: specify expected_stderr within restart_node in feature_pruning.py#5324UdjinM6 merged 1 commit intodashpay:developfrom
UdjinM6 merged 1 commit intodashpay:developfrom
Conversation
|
looks good. how about e19bd8a to clean things up a bit? |
kwvg
force-pushed
the
fix_feature_pruning
branch
from
779fc2f to
c2141ab
Compare
Co-authored-by: UdjinM6 <[email protected]>
kwvg
force-pushed
the
fix_feature_pruning
branch
from
c2141ab to
7157df6
Compare
PastaPastaPasta
approved these changes
Apr 16, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.I have commented my code, particularly in hard-to-understand areasN/AI have added or updated relevant unit/integration/functional/e2e testsN/AI have made corresponding changes to the documentationN/A