refactor: prefer using TxValidationState directly for unification with bitcoin implementation#5335
Merged
UdjinM6 merged 1 commit intodashpay:developfrom Apr 25, 2023
Merged
Conversation
…lementation Since last refactoring bitcoin#15921 and bitcoin#17004 the benefits of using maybe_error are less significants because the interface became simpler. In future it can be considered using universal `maybe_error` (Result) as proposed in PR dashpay#5109 instead this particular implementation
|
@PastaPastaPasta ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The benefits of using custom struct
maybe_erroris less significant since the interfaceTxValidationStatebecame simpler after refactorings from bitcoin#15921 and bitcoin#17004The refactoring of
maybe_erroras a class result from PR #5109 is still useful but not for case of TxValidationState.What was done?
Unified using TxValidationState in dash's related code.
How Has This Been Tested?
Run unit/functional tests
Breaking Changes
No breaking changes, logic are same.
Checklist: