fix(qt): provide correct data into intro dlg#5348
Merged
PastaPastaPasta merged 1 commit intodashpay:developfrom Apr 26, 2023
Merged
fix(qt): provide correct data into intro dlg#5348PastaPastaPasta merged 1 commit intodashpay:developfrom
PastaPastaPasta merged 1 commit intodashpay:developfrom
Conversation
failed to backport 13216 correctly in 4359
PastaPastaPasta
approved these changes
Apr 26, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 22, 2023
## Issue being fixed or feature implemented we failed to backport 13216 correctly in dashpay#4359 noticed this while reviewing/testing dashpay#5255 ## What was done? fix it ## How Has This Been Tested? run qt with `-resetguisetting` and check info with and without the patch on testnet for example (or tweak regtest params and test there) ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
we failed to backport 13216 correctly in #4359
noticed this while reviewing/testing #5255
What was done?
fix it
How Has This Been Tested?
run qt with
-resetguisettingand check info with and without the patch on testnet for example (or tweak regtest params and test there)Breaking Changes
n/a
Checklist: