fix(qt): fix few gui issues#5351
Merged
PastaPastaPasta merged 5 commits intodashpay:developfrom May 2, 2023
Merged
Conversation
knst
previously approved these changes
Apr 29, 2023
Collaborator
knst
left a comment
knst
left a comment
There was a problem hiding this comment.
TS_WARNING and TS_ERROR looks so much better.
tACK
may be also update TS_ERROR to TS_WARNING here?
src/qt/sendcoinsdialog.cpp:
questionString.append("<span style='" + GUIUtil::getThemedStyleQString(GUIUtil::ThemedStyle::TS_ERROR) + "'>");
questionString.append(tr("Warning: Using %1 with %2 or more inputs can harm your privacy and is not recommended").arg(strCoinJoinName).arg(10));
...
src/qt/sendcoinsdialog.cpp:
questionString.append("<span style='" + GUIUtil::getThemedStyleQString(GUIUtil::ThemedStyle::TS_ERROR) + "'>");
questionString.append(tr("<b>(%1 of %2 entries displayed)</b>").arg(displayedEntries).arg(messageEntries));
PastaPastaPasta
approved these changes
May 2, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
#800000looks ugly in Dark theme, use TS_ERROR like we did prior to 17453 backport (via backport: bitcoin#15584, #16060, #16465, #16477, #16680, #16714, #16941, #16991, #17453, #17696, #19058 (last batch for v19) #5255), also introduce TS_WARNING for#999900to unify thingsbefore:
after:using TS_WARNING in sendcoinsdialog:
before:
after:
What was done?
How Has This Been Tested?
run
dash-qt --regtest --nowallet --resetguisettingsBreaking Changes
n/a
Checklist: