backport: merge bitcoin#19791, #19911, #19910, #20217, #20649, #18458, #20811 (peer manager backports)#5352
Merged
PastaPastaPasta merged 10 commits intodashpay:developfrom May 11, 2023
Merged
Conversation
1dac8fa to
c10da1d
Compare
Member
|
Looks like there may be an issue with TSAN.. restarting that job to see if it's a once off |
|
dropping 20942 "fixes" tsan build issue it seems |
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
previously approved these changes
May 10, 2023
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
UdjinM6
requested changes
May 11, 2023
…_set with g_cs_orphans
5037d7f to
d663d47
Compare
PastaPastaPasta
approved these changes
May 11, 2023
Member
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for merging via merge commit
PastaPastaPasta
pushed a commit
that referenced
this pull request
May 26, 2023
…acktraces (#5375) ## Description Pull request was inspired by the need to debug lock problems when working on #5352. As far as I'm aware, only macOS has `-Werror=thread-safety` as part of its default `CXXFLAGS` despite the capability being present on Linux as well. This PR introduces thread safety checks for that into our thread sanitizer build. Additionally, since we're using Clang, something that on first glimpse, appears to be something that `stacktraces.cpp` isn't happy with, due to `-Wl,-wrap` being available only on GCC, that no longer seems to be the case, since the version of Clang with comes with `focal`, its `lld` _does_ have support for `-wrap` (see [man page for `lld` on `focal`](https://manpages.ubuntu.com/manpages/focal/en/man1/lld.1.html)). The current `stable` version of Clang/LLVM is 15, at the time of this pull request (see https://apt.llvm.org/) but `focal` ships with an older version, requiring us to use the official LLVM APT repository. I feel we should be testing with recent compilers alongside the ones shipped by LTS distributions. Certain bugs are only made apparent when testing on rolling release distros or distros that have faster update cycles, like Fedora (see #5295 for an illustration of that), which ship with more recent compilers. Until we overhaul our CI systems to test using those distros directly (our current infrastructure is centered around using a "development image" with an LTS distro as the base), this is the best we can do. A similar pull request testing against the latest GCC stable will be welcome as that is currently outside the scope of this PR as the changes made were to make sure that builds were operating as expected on Clang/LLVM 15. --------- Co-authored-by: UdjinM6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes