feat: mnlistdiff v20 CL sig quorums by ogabrielides · Pull Request #5377 · dashpay/dash

ogabrielides · 2023-05-17T17:59:33Z

Issue being fixed or feature implemented

Implementation of Randomness Beacon Part 3.

Starting from v20 activation fork, members for quorums are sorted using (if available) the best CL signature found in Coinbase.
If no CL signature is present yet, then the usual way is used (By using Blockhash instead)

The actual new way to shuffle is already implemented in #5366.

SPV clients also need to calculate members, but they only know block headers.
Since Coinbase is in the actual block, then they lack the required information to correctly calculate quorum members.

What was done?

Message MNLISTIDFF is enriched with a new field quorumsCLSigs. This field holds the Chainlock Signature required for each set of indexes corresponding to quorums in field newQuorums.
Protocol version has been bumped to 70230.
Clients with protocol version greater or equal to 70230 will receive the new field quorumsCLSigs.
The same field is returned in protx diff RPC.

Note:

Field quorumsCLSigs will populated only after v20 activation
If for one or more quorums, no non-null CL sig was found in CbTx then a null signature is returned in quorumsCLSigs.

How Has This Been Tested?

Functional test mininode's protocol version was bumped to 70230.
feature_llmq_rotation.py checks that quorumsCLSigs match in both P2P and RPC messages.

Breaking Changes

No

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

src/evo/simplifiedmns.cpp

src/evo/simplifiedmns.h

src/version.h

src/evo/simplifiedmns.h

github-actions · 2023-05-18T17:05:42Z

This pull request has conflicts, please rebase.

thephez

A few minor suggestions

doc/release-notes-5377.md

UdjinM6

utACK

thephez

Doc ACK 🙂

github-actions · 2023-06-11T17:31:22Z

This pull request has conflicts, please rebase.

doc/release-notes-5377.md

UdjinM6

re-utACK

PastaPastaPasta

Please see f838f95 c02bac5 and 63efe7f

Then, I am concerned about testing for this, I tried to break the test but couldn't really. I think any of these changes should break the tests

00f1a42
7f3f385
5c04684

Co-authored-by: thephez <[email protected]>

Co-authored-by: UdjinM6 <[email protected]>

…d quorums

ogabrielides · 2023-06-30T12:41:09Z

@PastaPastaPasta @UdjinM6

With the latest pushed change, quorum verification captures the disturbed returned CL caused by 7f3f385 5c04684.

src/version.h

UdjinM6

utACK

PastaPastaPasta

utACK for squash merge

Relates to dashpay/dash#5377

* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)

Relates to dashpay/dash#5377

* docs(rpc): update protx diff Relates to dashpay/dash#5377 * docs(rpc): add getindexinfo rpc Relates to dashpay/dash#5492 * docs(rpc): add gettxchainlocks Relates to dashpay/dash#5578 * docs(rpc): update getblock

* docs: deprecate MSG_LEGACY_TXLOCK_REQUEST Aligns with dashpay/dash#5483 * chore: update link to prev version of docs * docs: update mnlistdiff nversion location Relates to dashpay/dash#5450 * docs(p2p): update mnlistdiff Relates to dashpay/dash#5377 * docs: update cbtx for v3 Relates to dashpay/dash#5262 * docs: update mnhf with details of final implementation Relates to dashpay/dash#5469 and dashpay/dash#5505 * docs: note removal of NODE_GETUTXO Relates to dashpay/dash#5500 * chore: revert "docs: update mnhf with details of final implementation" This reverts commit 8e4bf6c since there may still be additional changes to the implementation (it's not merged)

* docs(rpc): update protx diff Relates to dashpay/dash#5377 * docs(rpc): add getindexinfo rpc Relates to dashpay/dash#5492 * docs(rpc): add gettxchainlocks Relates to dashpay/dash#5578 * docs(rpc): update getblock

ogabrielides marked this pull request as draft May 17, 2023 18:00

ogabrielides added RPC Some notable changes to RPC params/behaviour/descriptions P2P Some notable changes on p2p level labels May 17, 2023

ogabrielides added this to the 20 milestone May 17, 2023

ogabrielides marked this pull request as ready for review May 17, 2023 20:38

ogabrielides requested review from PastaPastaPasta, UdjinM6 and thephez May 17, 2023 20:39

knst reviewed May 18, 2023

View reviewed changes

src/evo/simplifiedmns.cpp Outdated Show resolved Hide resolved

src/evo/simplifiedmns.cpp Outdated Show resolved Hide resolved

src/evo/simplifiedmns.cpp Outdated Show resolved Hide resolved

src/evo/simplifiedmns.h Outdated Show resolved Hide resolved

UdjinM6 reviewed May 18, 2023

View reviewed changes

src/version.h Outdated Show resolved Hide resolved

src/evo/simplifiedmns.h Outdated Show resolved Hide resolved

github-actions bot added the needs rebase label May 18, 2023

thephez reviewed May 18, 2023

View reviewed changes

doc/release-notes-5377.md Outdated Show resolved Hide resolved

doc/release-notes-5377.md Outdated Show resolved Hide resolved

doc/release-notes-5377.md Outdated Show resolved Hide resolved

doc/release-notes-5377.md Outdated Show resolved Hide resolved

github-actions bot removed the needs rebase label May 18, 2023

ogabrielides requested review from UdjinM6 and thephez May 19, 2023 06:48

UdjinM6 previously approved these changes May 20, 2023

View reviewed changes

thephez approved these changes May 23, 2023

View reviewed changes

github-actions bot added the needs rebase label Jun 11, 2023

ogabrielides dismissed UdjinM6’s stale review via b312a44 June 13, 2023 09:26

github-actions bot removed the needs rebase label Jun 13, 2023

ogabrielides requested a review from UdjinM6 June 13, 2023 11:09

UdjinM6 requested changes Jun 16, 2023

View reviewed changes

doc/release-notes-5377.md Outdated Show resolved Hide resolved

ogabrielides requested a review from UdjinM6 June 16, 2023 13:13

UdjinM6 previously approved these changes Jun 16, 2023

View reviewed changes

PastaPastaPasta requested changes Jun 21, 2023

View reviewed changes

ogabrielides dismissed UdjinM6’s stale review via e7cb177 June 21, 2023 11:50

UdjinM6 mentioned this pull request Jun 22, 2023

feat: mnlistdiff move nversion to first position #5450

Merged

5 tasks

github-actions bot added the needs rebase label Jun 26, 2023

ogabrielides and others added 9 commits June 28, 2023 19:10

Apply suggestions from code review

94b141a

Co-authored-by: thephez <[email protected]>

refactoring

ab5814e

Update doc/release-notes-5377.md

592ae62

Co-authored-by: UdjinM6 <[email protected]>

simplify logic by using the fact that quorumIndex is 0 for non-rotate…

c23d259

…d quorums

use enumerate

cdb1b8e

refactor / modernize

d2232d6

Update release-notes-5377.md

ad529f4

verify quorum members based on clsigs

792bdc8

cleanup

cdd8e8e

ogabrielides requested review from PastaPastaPasta and UdjinM6 June 28, 2023 17:17

Enforce divert CL in CbTx before one quorum cycle

93fbd16

typo fix

735d34a

PastaPastaPasta reviewed Jul 4, 2023

View reviewed changes

src/version.h Show resolved Hide resolved

ogabrielides added 2 commits July 4, 2023 22:05

Bumped MIN_MASTERNODE_PROTO_VERSION

14a4d5a

restored empty lines

410c197

ogabrielides requested a review from PastaPastaPasta July 4, 2023 19:07

UdjinM6 approved these changes Jul 7, 2023

View reviewed changes

PastaPastaPasta approved these changes Jul 10, 2023

View reviewed changes

PastaPastaPasta merged commit 494b5c7 into dashpay:develop Jul 10, 2023

ogabrielides deleted the mnlistdiff_quorums_clsigs_spv branch July 11, 2023 13:04

thephez added a commit to thephez/docs-core that referenced this pull request Aug 16, 2023

docs(p2p): update mnlistdiff

35fe327

Relates to dashpay/dash#5377

thephez added a commit to thephez/docs-core that referenced this pull request Oct 3, 2023

docs(rpc): update protx diff

0e2f9d9

Relates to dashpay/dash#5377

PastaPastaPasta mentioned this pull request Oct 19, 2023

chore: bump minimum mn proto version for v20 #5620

Closed

5 tasks

Conversation

ogabrielides commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 18, 2023

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

thephez left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 11, 2023

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

ogabrielides commented Jun 30, 2023

Uh oh!

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

PastaPastaPasta left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ogabrielides commented May 17, 2023 •

edited

Loading