refactor: cleanup CChainParams unused data and functions#5474
Merged
PastaPastaPasta merged 2 commits intodashpay:developfrom Jul 4, 2023
Merged
refactor: cleanup CChainParams unused data and functions#5474PastaPastaPasta merged 2 commits intodashpay:developfrom
PastaPastaPasta merged 2 commits intodashpay:developfrom
Conversation
It removes 2 unused flags: - BIP9CheckMasternodesUpgraded from CChainParams - check_mn_protocol from versionbitsinfo These flags have no meaning since 17c792c (PR dashpay#2594) The TODO in removed code is super-seeded by new way to validate MN version in hard-fork (see dashpay#5469 and DIP0023 for more details)
PastaPastaPasta
approved these changes
Jul 3, 2023
Member
PastaPastaPasta
left a comment
PastaPastaPasta
left a comment
There was a problem hiding this comment.
utACK for squash merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
During implementation #5469 (master node hard-fork) I noticed that some parts of
CChainParamsare deprecated and can be removed.What was done?
CChainParamsthat have no implementation at all:BIP9CheckMasternodesUpgradedfromCChainParamsand a flagcheck_mn_protocolfromversionbitsinfo.(to follow-up Directly use deterministicMNManager instead of compat code in CMasternodeMan #2594)
How Has This Been Tested?
Run functional/unit tests.
Breaking Changes
N/A
Checklist: